-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Add new error case for mixed x axes #102861
Conversation
Pinging @elastic/kibana-app (Team:KibanaApp) |
@dej611 True, but it doesn't seem to break any formatting and looks like something that could easily happen while configuring a chart, so IMHO it's fine. We allow other kind of mixed charts as well (e.g. top values + filters) because they work together. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
}, | ||
}), | ||
longMessage: i18n.translate('xpack.lens.xyVisualization.dataTypeFailureXOrdinalLong', { | ||
defaultMessage: `Data type mismatch for the {axis}. Cannot mix interval and ordinal scale types.`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The terms interval
and ordinal
are a little confusing, maybe it's enough to say Data type mismatch for the {axis}, use a different function
?
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Fixes #97427
Treat mixed interval/ordinal axes as an error because the x axis can't be rendered in a meaningful way in these situations.