Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskipping test to test on Firefox. #102839

Merged
merged 3 commits into from
Jun 22, 2021
Merged

Unskipping test to test on Firefox. #102839

merged 3 commits into from
Jun 22, 2021

Conversation

cuff-links
Copy link
Contributor

Closes #84440

Summary

This PR was opened to investigate Grok Debugger failures on Firefox.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cuff-links cuff-links marked this pull request as ready for review June 22, 2021 03:42
@cuff-links cuff-links added v7.14.0 v8.0.0 Feature:Grok Debugger Dev Tools Grok Debugger feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Jun 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-management (Team:Stack Management)

@cuff-links cuff-links added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes labels Jun 22, 2021
yuliacech
yuliacech approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cuff-links,
thanks a lot for looking into this skipped test! I couldn't check the logs from last flaky runs, since it's been a while. I'm good with enabling the test now and see if we notice any new flaky runs to investigate later.

@cuff-links cuff-links merged commit 494a841 into elastic:master Jun 22, 2021
@kibanamachine kibanamachine mentioned this pull request Jun 22, 2021
Closed
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 22, 2021
@kibanamachine
Unskipping test to test on Firefox. (elastic#102839)
f044a3b 
* Unskipping test to test on Firefox.

* Added .only to only run those tests

* Reenabled test after troubleshooting tests. No failures on FF.
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 24, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 102839 or prevent reminders by adding the backport:skip label.

3 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 102839 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 102839 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 102839 or prevent reminders by adding the backport:skip label.

@cuff-links cuff-links mentioned this pull request Jun 29, 2021
Closed
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 102839 or prevent reminders by adding the backport:skip label.

@cuff-links cuff-links added backport:skip This commit does not require backporting and removed auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 30, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuliacech yuliacech yuliacech approved these changes

@alisonelizabeth alisonelizabeth Awaiting requested review from alisonelizabeth

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Grok Debugger Dev Tools Grok Debugger feature release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
4 participants
@cuff-links @kibanamachine @elasticmachine @yuliacech