Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Osquery telemetry usage bug #102762

Merged
merged 2 commits into from
Jun 21, 2021
Merged

Osquery telemetry usage bug #102762

merged 2 commits into from
Jun 21, 2021

Conversation

lykkin
Copy link
Contributor

@lykkin lykkin commented Jun 21, 2021 •
edited
Loading

Summary

Fixes the error

server    log   [13:47:55.586] [warning][collector-set][plugins][usage-collection][usageCollection] TypeError: Cannot use 'in' operator to search for 'max_rss' in undefined
 ...

in the circumstances where there are missing aggregation buckets.

@lykkin lykkin added release_note:fix v8.0.0 v7.14.0 Feature:Osquery Security Solution Osquery feature auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 21, 2021
@lykkin lykkin self-assigned this Jun 21, 2021
@lykkin lykkin requested a review from a team as a code owner June 21, 2021 15:38
@lykkin lykkin added the Team:Asset Management Security Asset Management Team label Jun 21, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-asset-management (Team:Asset Management)

@lykkin lykkin enabled auto-merge (squash) June 21, 2021 16:05
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lykkin

@lykkin lykkin merged commit 4c700ab into elastic:master Jun 21, 2021
@kibanamachine kibanamachine mentioned this pull request Jun 21, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 21, 2021
@lykkin @kibanamachine
Osquery telemetry usage bug (elastic#102762)
bf22064 
* guard for null metrics query

* added some tests for the beat usage metric extraction function
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 23, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 24, 2021
kibanamachine added a commit that referenced this pull request Jun 24, 2021
@kibanamachine @lykkin
Osquery telemetry usage bug (#102762) (#102785)
4ffc79a 
* guard for null metrics query

* added some tests for the beat usage metric extraction function

Co-authored-by: Bryan Clement <bclement01@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

Assignees

@lykkin lykkin

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Osquery Security Solution Osquery feature release_note:fix Team:Asset Management Security Asset Management Team v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lykkin @elasticmachine @kibanamachine @patrykkopycinski