Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Errors: Fix panels styles #102734

Merged
merged 2 commits into from
Jun 21, 2021
Merged

[APM] Errors: Fix panels styles #102734

merged 2 commits into from
Jun 21, 2021

Conversation

formgeist
Copy link
Contributor

Summary

In relation to the new page template in APM, the Errors UI didn't get updated, so updating the panel styles.

Before

Screenshot 2021-06-21 at 14 19 31

Screenshot 2021-06-21 at 14 19 47

After

Screenshot 2021-06-21 at 14 16 27

Screenshot 2021-06-21 at 14 16 38

@formgeist formgeist added Team:APM All issues that need APM UI Team support release_note:skip Skip the PR/issue when compiling release notes polish v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed amsterdam labels Jun 21, 2021
@formgeist formgeist self-assigned this Jun 21, 2021
@formgeist formgeist requested a review from a team as a code owner June 21, 2021 12:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

sorenlouv
sorenlouv approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I missed those

@formgeist
Copy link
Contributor Author

Thanks, I missed those

Me too - I think at the time I was updating the others, I couldn't get Errors to load at all, so I must've forgotten 😅 Thanks!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.3MB 4.3MB +260.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @formgeist

@formgeist formgeist merged commit 17e496c into elastic:master Jun 21, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 21, 2021
@formgeist @kibanamachine
[APM] Errors: Fix panels styles (elastic#102734)
470e54e
@kibanamachine kibanamachine mentioned this pull request Jun 21, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

@formgeist formgeist deleted the apm-fix-errors-ui-panels-styles branch June 21, 2021 14:54
kibanamachine added a commit that referenced this pull request Jun 21, 2021
@kibanamachine @formgeist
[APM] Errors: Fix panels styles (#102734) (#102748)
04ae473 
Co-authored-by: Casper Hübertz <casper@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees

@formgeist formgeist

Labels
amsterdam auto-backport Deprecated - use backport:version if exact versions are needed polish release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@formgeist @elasticmachine @kibanamachine @sorenlouv