Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Functional tests - stabilize setupModule tests #102708

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Jun 21, 2021

Summary

This PR stabilizes the setupModule API tests by increasing the timeout for the jobs to finish.

Details

  • Some of the module jobs are running a bit longer and can exceed the two minute timeout we're currently giving the jobs to finish.
  • waitForJobState and waitForDatafeedState are now taking an optional parameter to override the default timeout (the setupModule tests are calling it now with a four minute timeout).
  • The order of the checks waitForDatafeedState and waitForJobState is now changed: we're first waiting for the datafeed (as the will be stopped first) and then for the job state.

Closes #102681

@pheyos pheyos self-assigned this Jun 21, 2021
@pheyos pheyos requested a review from a team as a code owner June 21, 2021 09:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@pheyos
Copy link
Member Author

pheyos commented Jun 21, 2021

Checking test stability in a flaky test runner job ... no failure in 50 runs ✔️

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @pheyos

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pheyos pheyos merged commit e97cfad into elastic:master Jun 21, 2021
@pheyos pheyos added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 21, 2021
@pheyos pheyos deleted the stabilize_module_tests branch June 21, 2021 14:11
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 21, 2021
This PR stabilizes the `setupModule` API tests by increasing the timeout for the jobs to finish.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 21, 2021
This PR stabilizes the `setupModule` API tests by increasing the timeout for the jobs to finish.
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.13
7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 21, 2021
This PR stabilizes the `setupModule` API tests by increasing the timeout for the jobs to finish.

Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
kibanamachine added a commit that referenced this pull request Jun 21, 2021
This PR stabilizes the `setupModule` API tests by increasing the timeout for the jobs to finish.

Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed :ml release_note:skip Skip the PR/issue when compiling release notes test-api-integration v7.13.3 v7.14.0 v8.0.0
Projects
None yet
4 participants