-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Dont trigger onChange when the same index pattern is selected #102652
[Discover] Dont trigger onChange when the same index pattern is selected #102652
Conversation
@elasticmachine merge upstream |
…-onchange-when-same-indexpattern
…n-same-indexpattern' of github.com:kertal/kibana into kertal-pr-2021-06-18-discover-dont-trigger-onchange-when-same-indexpattern
Pinging @elastic/kibana-app (Team:KibanaApp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
src/plugins/discover/public/application/apps/main/components/sidebar/change_indexpattern.tsx
Show resolved
Hide resolved
@elasticmachine merge upstream |
…-onchange-when-same-indexpattern
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @kertal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, haven't checked locally.
Summary
This PR changes the behavior of the index pattern selection in Discover.
If the the same index pattern is selected, there's no follow up action triggered.
Fixes #102587
Checklist