Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Dont trigger onChange when the same index pattern is selected #102652

Conversation

kertal
Copy link
Member

@kertal kertal commented Jun 18, 2021

Summary

This PR changes the behavior of the index pattern selection in Discover.
If the the same index pattern is selected, there's no follow up action triggered.

Fixes #102587

Checklist

@kertal kertal self-assigned this Jun 18, 2021
@kertal kertal added Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jun 18, 2021
@kertal
Copy link
Member Author

kertal commented Jun 21, 2021

@elasticmachine merge upstream

…n-same-indexpattern' of github.com:kertal/kibana into kertal-pr-2021-06-18-discover-dont-trigger-onchange-when-same-indexpattern
@kertal kertal added v7.14.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Jun 21, 2021
@kertal kertal marked this pull request as ready for review June 21, 2021 19:48
@kertal kertal requested a review from a team June 21, 2021 19:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal kertal requested review from majagrubic and LeeDr June 21, 2021 19:49
Copy link
Contributor

@dimaanj dimaanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kertal
Copy link
Member Author

kertal commented Jun 23, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 431.1KB 431.2KB +31.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal

Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, haven't checked locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discover hangs when you re-select the current index pattern
5 participants