-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Transforms: Converts management pages to new layout #102648
[ML] Transforms: Converts management pages to new layout #102648
Conversation
Pinging @elastic/ml-ui (:ml) |
<EuiFlexGroup justifyContent="spaceAround"> | ||
<EuiFlexItem grow={false}> | ||
<EuiPageContent verticalPosition="center" horizontalPosition="center" color="danger"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ Thanks for this PR @peteharverson !
QQ: I noticed that this error empty state is not vertically centered (in the screenshot) and my guess is that it has to do with the flex group/item wrapper. Does removing the them get it centered? Otherwise, I'd continue to look at any wrappers between the last .euiPageContentBody
provided by the template, and your content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Screenshots and quick scan of code LGTM! Thanks @peteharverson
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack Accessibility Tests.x-pack/test/accessibility/apps/spaces·ts.Kibana spaces page meets a11y validations a11y test for space selection pageStandard Out
Stack Trace
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…103236) * [ML] Transforms: Converts management pages to new layout * [ML] Fix vertical centering of error state in app Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Pete Harverson <peteharverson@users.noreply.github.com>
Summary
Updates the Transforms management app to conform to the new layout for page panels, headers and error states, as outlined in #101336.
Part of #102315
Examples before changes:
Examples after changes:
Checklist