-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Query] Use a minimal index pattern interface for es query #102364
Changes from 16 commits
148af16
0b79d06
e5f9f80
83645da
33f7a87
6b51a9a
04206fb
3f895f4
4248be7
b1ccf5c
e02bd98
9ab64da
6347118
508ed0e
25884bb
51c490b
cdb1f82
c49630b
e611902
1bab47e
308ec01
03ca054
903b8f4
68a7d27
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
|
||
import { IFieldType } from '../../index_patterns'; | ||
|
||
export interface MinimalIndexPattern { | ||
fields: IFieldType[]; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Isn't the dependency on FWIW, if it starts to feel weird having all of this stuff crammed in a Neither option feels great, just wanted to mention it as something to consider. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I intend to handle |
||
id?: string; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattkime do you have a better name for this?
And what do you think in general?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine. Its a bit hacky but it solves the problem without increasing complexity.