-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Improve performance of Fleet setup #102219
Changes from 13 commits
0bd33ac
a9d1051
dd27708
affa5b9
8cf78d6
9e1026e
87560af
ddf3633
825bbf1
3f85ec2
36cb102
54720f2
a69b64c
b400b9d
e229c7d
3e3a2dc
7142778
1e46532
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import React from 'react'; | ||
import { FormattedMessage } from '@kbn/i18n/react'; | ||
import { EuiEmptyPrompt, EuiLoadingSpinner } from '@elastic/eui'; | ||
|
||
export const FleetSetupLoading: React.FunctionComponent = () => ( | ||
<EuiEmptyPrompt | ||
title={ | ||
<h2> | ||
<FormattedMessage id="xpack.fleet.setup.titleLabel" defaultMessage="Loading Fleet..." /> | ||
</h2> | ||
} | ||
titleSize="m" | ||
body={<EuiLoadingSpinner size="xl" />} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. after #101334 is merged, we can take advantage of the new empty prompt loading pattern that was recently added to EUI which looks a bit nicer. not a blocker for this PR, we can come back to adjust it There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wanted to use that, but Kibana doesn't use yet the right version of EUI. Let's keep track of it |
||
/> | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the table! Does
requiredPackages
just mean that they are not removable? I think that's what I'm seeing from the code. Maybe we should change it tounremovable
or something.required
makes me think that it must be installed by just reading the name. The table helps clarify it though 😄