Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Fixes onDestroy handler #101959

Merged
merged 2 commits into from
Jun 22, 2021
Merged

[Canvas] Fixes onDestroy handler #101959

merged 2 commits into from
Jun 22, 2021

Conversation

crob611
Copy link
Contributor

@crob611 crob611 commented Jun 10, 2021

Summary

When I moved around the renderer handlers, our onDestroy method got missed, so some stuff isn't working. This fixes the onDestroy handler.

@crob611 crob611 added review loe:small Small Level of Effort v8.0.0 release_note:skip Skip the PR/issue when compiling release notes impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 10, 2021
@crob611 crob611 requested a review from a team as a code owner June 10, 2021 20:17
@crob611 crob611 added Feature:Canvas Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Jun 10, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@crob611
Copy link
Contributor Author

crob611 commented Jun 22, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.3MB 1.3MB +31.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@crob611 crob611 merged commit 1397461 into elastic:master Jun 22, 2021
@kibanamachine kibanamachine mentioned this pull request Jun 22, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jun 22, 2021
@kibanamachine
Fixes onDestroy handler (elastic#101959)
5935acc 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 22, 2021
@kibanamachine
Fixes onDestroy handler (#101959) (#102931)
b911f5d 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Corey Robertson <corey.robertson@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poffdeluxe poffdeluxe poffdeluxe approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Canvas impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crob611 @elasticmachine @kibanamachine @poffdeluxe