[APM] Visual improvements for new APM layout with left navigation #101360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/apm-ui (Team:apm) |
sorenlouv
added
release_note:skip
|
Thanks @formgeist! |
sorenlouv
force-pushed
the
apm-minor-tweaks-to-new-layout
branch
from
5b95d8a
to
fea2b90
Compare
sorenlouv
changed the title
sorenlouv
force-pushed
the
apm-minor-tweaks-to-new-layout
branch
from
8a0e17f
to
306e128
Compare
sorenlouv
changed the title
streamich
approved these changes
Jun 7, 2021
sorenlouv
commented
Jun 7, 2021
x-pack/plugins/apm/public/components/app/service_node_overview/index.tsx
Outdated
Show resolved
Hide resolved
sorenlouv
commented
Jun 7, 2021
Comment on lines
+260
to
304
| export function EditAgentConfigurationRouteView(props: RouteComponentProps) { | ||
| const { search } = props.history.location; | ||
|
|
||
| // typescript complains because `pageStop` does not exist in `APMQueryParams` | ||
| // Going forward we should move away from globally declared query params and this is a first step | ||
| // @ts-expect-error | ||
| const { name, environment, pageStep } = toQuery(search); | ||
|
|
||
| const res = useFetcher( | ||
| (callApmApi) => { | ||
| return callApmApi({ | ||
| endpoint: 'GET /api/apm/settings/agent-configuration/view', | ||
| params: { query: { name, environment } }, | ||
| }); | ||
| }, | ||
| [name, environment] | ||
| ); | ||
|
|
||
| return ( | ||
| <ApmMainTemplate pageTitle="Settings"> | ||
| <SettingsTemplate {...props}> | ||
| <AgentConfigurationCreateEdit | ||
| pageStep={pageStep || 'choose-settings-step'} | ||
| existingConfigResult={res} | ||
| /> | ||
| </SettingsTemplate> | ||
| </ApmMainTemplate> | ||
| ); | ||
| } | ||
|
|
||
| export function CreateAgentConfigurationRouteView(props: RouteComponentProps) { | ||
| const { search } = props.history.location; | ||
|
|
||
| // Ignoring here because we specifically DO NOT want to add the query params to the global route handler | ||
| // @ts-expect-error | ||
| const { pageStep } = toQuery(search); | ||
|
|
||
| return ( | ||
| <ApmMainTemplate pageTitle="Settings"> | ||
| <SettingsTemplate {...props}> | ||
| <AgentConfigurationCreateEdit | ||
| pageStep={pageStep || 'choose-service-step'} | ||
| /> | ||
| </SettingsTemplate> | ||
| </ApmMainTemplate> |
There was a problem hiding this comment.
This is not new but was simply moved from another file
dgieselaar
approved these changes
Jun 7, 2021
| }; | ||
| }) { | ||
| }: Props) { | ||
| const tabs = useTabs({ serviceName, selectedTab }); |
There was a problem hiding this comment.
I like the use of hooks here 👍
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 7, 2021
* master: (90 commits) Fix UI breaks on providing long search keyword in 'Search Box' (elastic#101385) Adds css class to EuiDescriptionListDescription in order to break word on exception details card (elastic#101481) [Lens] Increase timings for drag and drop tests (elastic#101380) [Lens] Fix editor react error on configuration panel (elastic#101367) [Fleet] Move integrations to a separate app (elastic#99848) Fix incorrect message displayed on importing Timeline Templates (elastic#101288) [Cases] RBAC (elastic#95058) [APM] Visual improvements for new APM layout with left navigation (elastic#101360) [master] More precise alerts matching (elastic#99820) [Lens] Value in legend (elastic#101353) Revert "[Reporting] ILM policy for managing reporting indices (elastic#100130)" (elastic#101358) [Discover] Fix header row of data grid in Firefox (elastic#101374) Add link to advanced setting in Discover (elastic#101154) Url service locators (elastic#101045) [Timelion] Update the removal message to mention the exact version (elastic#100994) [Security Solution][Detection Engine] Test cases for alias failure test cases where we don't copy aliases correctly (elastic#101437) [Event Log] Adding `type_id` to saved object array in event log (elastic#100939) [Reporting] Add `location.url` info to console message logs (elastic#101427) [Security Solutions][Detection Engine] Fixes timestamp bugs within source indexes when the formats are not ISO8601 format (elastic#101349) Improve Task Manager instrumentation (elastic#99160) ...
sorenlouv
added
the
auto-backport
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to: #101044
Closes: #101355
TODO
Truncation or wrapping missing in the PageHeader title(blocked) [APM] Solution navigation UI polish #101355