Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App Search] Remove external "Launch App Search" button #100815

Merged
merged 3 commits into from
Jun 23, 2021

Conversation

cee-chen
Copy link
Member

@cee-chen cee-chen commented May 27, 2021

Summary

Look at me. I am the captain App Search now.

Checklist

Release note

Adds a full management experience for the Elastic Enterprise Search solution. Enterprise Search in Kibana is initially a beta feature. See User interfaces in the Enterprise Search documentation for details.

@cee-chen cee-chen added Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels May 27, 2021
@cee-chen cee-chen requested a review from a team May 27, 2021 18:49
@cee-chen cee-chen requested review from a team as code owners May 27, 2021 18:55
@cee-chen
Copy link
Member Author

cee-chen commented May 27, 2021

Another thought - I was joking around with Davey about this being a "pop-the-champagne" type PR, but it occurred to me that we do actually need to give the Kibana folks a PR with release notes for the entire plugin at some point:

https://www.elastic.co/guide/en/kibana/master/contributing.html#_create_the_release_notes_text

This PR could be it, or we could maybe just open up another small PR for release notes later.

What do y'all think? @richkuz @chriscressman? I have no issues for leaving this PR open until we have release notes ready.

@cee-chen
Copy link
Member Author

For the Telemetry team - we're removing the button connected to this UI metric (2876f0e), so I figured I should remove the metric+schema entirely. If that's a pain and you'd prefer we just leave the schema alone just let me know.

@chriscressman
Copy link
Contributor

@constancecchen ++ to using this as the PR to represent the plugin.

@cee-chen
Copy link
Member Author

Awesome, thanks so much Chris! Timeline-wise, when do you think we'll have release notes ready for Kibana? No rush at all and anytime before the 7.14 FF is fine, mostly just asking for my own internal time-keeping

@chriscressman
Copy link
Contributor

when do you think we'll have release notes ready for Kibana?

Let's say shortly before FF. I'll be on vacation for a week following the current App Search sprint. After I get back, I need to make a list of all technical writing concerns for the Kibana migration. If you already have a starting point for this list somewhere, that would help!

@chriscressman chriscressman added release_note:feature Makes this part of the condensed release notes and removed release_note:skip Skip the PR/issue when compiling release notes labels Jun 23, 2021
@chriscressman
Copy link
Contributor

@constancecchen I completed the steps required for the Kibana release notes. I added the release note text and updated the release note label.

@cee-chen
Copy link
Member Author

Wooo!! Thanks so much Chris, I'm super excited! Going to get this PR rebased up and ready to go 🚀 🚀

@cee-chen cee-chen enabled auto-merge (squash) June 23, 2021 16:27
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 1447 1446 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.1MB 2.1MB -705.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 23, 2021
* Remove markup

* Remove i18n translations

* Remove telemetry metric
kibanamachine added a commit that referenced this pull request Jun 23, 2021
…03155)

* Remove markup

* Remove i18n translations

* Remove telemetry metric

Co-authored-by: Constance <constancecchen@users.noreply.github.com>
@cee-chen cee-chen deleted the remove-external-as-button branch June 24, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Plugins release_note:feature Makes this part of the condensed release notes v7.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants