-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[App Search] Remove external "Launch App Search" button #100815
Conversation
d69a2ed
to
2876f0e
Compare
Another thought - I was joking around with Davey about this being a "pop-the-champagne" type PR, but it occurred to me that we do actually need to give the Kibana folks a PR with release notes for the entire plugin at some point: https://www.elastic.co/guide/en/kibana/master/contributing.html#_create_the_release_notes_text This PR could be it, or we could maybe just open up another small PR for release notes later. What do y'all think? @richkuz @chriscressman? I have no issues for leaving this PR open until we have release notes ready. |
For the Telemetry team - we're removing the button connected to this UI metric (2876f0e), so I figured I should remove the metric+schema entirely. If that's a pain and you'd prefer we just leave the schema alone just let me know. |
@constancecchen ++ to using this as the PR to represent the plugin. |
Awesome, thanks so much Chris! Timeline-wise, when do you think we'll have release notes ready for Kibana? No rush at all and anytime before the 7.14 FF is fine, mostly just asking for my own internal time-keeping |
Let's say shortly before FF. I'll be on vacation for a week following the current App Search sprint. After I get back, I need to make a list of all technical writing concerns for the Kibana migration. If you already have a starting point for this list somewhere, that would help! |
@constancecchen I completed the steps required for the Kibana release notes. I added the release note text and updated the release note label. |
Wooo!! Thanks so much Chris, I'm super excited! Going to get this PR rebased up and ready to go 🚀 🚀 |
2876f0e
to
2e5cb23
Compare
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
* Remove markup * Remove i18n translations * Remove telemetry metric
Summary
Look at me. I am the
captainApp Search now.Checklist
Release note
Adds a full management experience for the Elastic Enterprise Search solution. Enterprise Search in Kibana is initially a beta feature. See User interfaces in the Enterprise Search documentation for details.