Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Time to Visualize] Implement new Migration System for Dashboard #81912

Closed
ThomThomson opened this issue Oct 28, 2020 · 2 comments
Closed

[Time to Visualize] Implement new Migration System for Dashboard #81912

ThomThomson opened this issue Oct 28, 2020 · 2 comments
Labels
enhancement New value added to drive a business result Feature:Dashboard Dashboard related features Feature:Telemetry Project:TimeToVisualize Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

Describe the feature:
The new migration system as described in #80973 must be used in dashboard in order to ensure that telemetry is collected on the latest state.

Currently the Dashboard Panel migration system runs on load on the front end. It migrates to the newest panel state from whichever stale panel state might be stored in the dashboard saved object.

The embeddable telemetry function will be server-side, will run through the dashboard saved objects, and will only work on panels with the latest state.
This means that there may be a chance that the telemetry service will run against stale panel states.

To solve this, we should implement the new migration system, so in the event of a version upgrade, the migrations are run at start up, and the telemetry collector can assume that the latest state is present.

@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features enhancement New value added to drive a business result Feature:Telemetry Project:TimeToVisualize labels Oct 28, 2020
@timroes timroes added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Mar 11, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson
Copy link
Contributor Author

Closing these, as the persistable state system has been implemented in Dashboard, and all panels are migrated to their latest version during saved object migrations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Dashboard Dashboard related features Feature:Telemetry Project:TimeToVisualize Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

3 participants