Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs UI] Plain link-to route misinterprets static suffix as source id #74916

Closed
weltenwort opened this issue Aug 12, 2020 · 1 comment · Fixed by #74502
Closed

[Logs UI] Plain link-to route misinterprets static suffix as source id #74916

weltenwort opened this issue Aug 12, 2020 · 1 comment · Fixed by #74502
Assignees
@weltenwort
Labels
bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.1
Milestone
Logs UI 7.10

Comments

@weltenwort
Copy link
Member

weltenwort commented Aug 12, 2020 •
edited by zube bot
Loading

Summary

In #61162 the route /app/logs/link-to/:sourceId?/logs was changed to /app/logs/link-to/:sourceId? in a non-backwards-compatible way. As a consequence the second logs to /app/logs/link-to/logs is now interpreted as the source id, which breaks various links from other applications such as APM.

Proposed solution

Restore the removed route such that /app/logs/link-to/:sourceId?/logs has a higher priority than /app/logs/link-to/:sourceId?.
@weltenwort weltenwort added bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.1 labels Aug 12, 2020
@weltenwort weltenwort added this to the Logs UI 7.10 milestone Aug 12, 2020
@weltenwort weltenwort self-assigned this Aug 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@weltenwort weltenwort mentioned this issue Aug 12, 2020
Merged
weltenwort added a commit to weltenwort/kibana that referenced this issue Aug 17, 2020
@weltenwort
[7.x] [Logs UI] Partial backport: Remove apollo deps from log link-to…
17e24fa 
… routes

Partially backports the following commits to 7.x:
 - [Logs UI] Remove apollo deps from log link-to routes (elastic#74502)

This backport only includes the route fix for elastic#74916 to make it
available in 7.9.x.
@weltenwort weltenwort mentioned this issue Aug 17, 2020
Merged
weltenwort added a commit that referenced this issue Aug 17, 2020
@weltenwort
[7.9] [Logs UI] Partial backport: Remove apollo deps from log link-to…
eb4dcc7 
… routes (#75140)

Partially backports the following commits to 7.x:
 - [Logs UI] Remove apollo deps from log link-to routes (#74502)

This backport only includes the route fix for #74916 to make it
available in 7.9.x.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weltenwort weltenwort

Labels
bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.1
Projects
None yet
Milestone
Logs UI 7.10
Development

Successfully merging a pull request may close this issue.

[Logs UI] Remove apollo deps from log link-to routes weltenwort/kibana
2 participants
@weltenwort @elasticmachine