Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saving url-parameterized dashboards overwrites placeholders #662

Closed
falkenbt opened this issue Nov 6, 2013 · 2 comments
Closed

saving url-parameterized dashboards overwrites placeholders #662

falkenbt opened this issue Nov 6, 2013 · 2 comments
Labels
notabug When the issue is closed this label Indicates that it wasn't a bug

Comments

@falkenbt
Copy link

falkenbt commented Nov 6, 2013

Referring to
#168 (comment)

When calling http://localhost:8000/index.html#/dashboard/elasticsearch/Awesomesauce?query=somequeryhere
and saving (or exporting) it, the placeholder {{query}} is being overwritten by the value ("somequeryhere") in the json.

IMHO the variables should optionally be skipped when saving the dashboard.

Or is this a feature? :)

@rashidkpc
Copy link
Contributor

This known and expected behavior. The variable is interpreted by the template renderer before the dashboard is loaded, there is no way to keep a reference to it for saving.

@falkenbt
Copy link
Author

falkenbt commented Nov 6, 2013

I see. This makes developing these dashboards a bit challenging. But I don't have a good solution either.
Maybe we can put an inline json editor on the roadmap? That would make things a bit easier.

BTW the link to the example is dead: https://github.com/elasticsearch/kibana/blob/master/dashboards/logstash.js

w33ble pushed a commit to w33ble/kibana that referenced this issue Sep 13, 2018
* Added EuiButtonIcon to remove icon

* Added EUI to asset manager. Cleaned up styles.

* Fixed positioning of images in asset manager

* Resized images in asset_manager

* Fixed asset id

* Cleaned up asset manager styles

* Added EUI to confirm modal

* Changed fullScreenIconColor to dark in asset manager

* Reverted changes to remove-icon

* Rearranged asset buttons

* Cleaned up styles

* Fixed image position in asset thumbnail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notabug When the issue is closed this label Indicates that it wasn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants
@falkenbt @rashidkpc and others