Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Removed header styling for stack traces without source lines #23560

Closed
5 tasks done
formgeist opened this issue Sep 27, 2018 · 1 comment
Closed
5 tasks done

[APM] Removed header styling for stack traces without source lines #23560

formgeist opened this issue Sep 27, 2018 · 1 comment
Assignees
@ogupte
Labels
Team:APM All issues that need APM UI Team support

Comments

@formgeist
Copy link
Contributor

formgeist commented Sep 27, 2018 •
edited by ogupte
Loading

Fixes #23389

It's the most common case that source lines are not included for stack traces, at least for transactions, so it'd be better to display the headings without the header style we use for the full stack trace box.

  • Split styling for full stack trace code box and headings without source lines
  • Remove heading margin, border and background for app frame headings
  • Change library frame headings style
    • Font-weight normal
    • Color main text #666666, except in which stays light-grey.

Full stack trace code box style
Screen Shot 2018-09-27 at 11.03.48.png

Heading without styling when source lines are not available
Screen Shot 2018-09-27 at 11.07.55.png
@formgeist formgeist added Team:APM All issues that need APM UI Team support [zube]: Inbox labels Sep 27, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@formgeist formgeist mentioned this issue Sep 27, 2018
Closed
@jasonrhodes jasonrhodes mentioned this issue Sep 27, 2018
Closed
7 tasks
@ogupte ogupte self-assigned this Nov 29, 2018
ogupte added a commit to ogupte/kibana that referenced this issue Nov 30, 2018
@ogupte
[APM] fixes elastic#23560 by separating frame headers from code previ…
5ac4119 
…ew and only displaying code preview when stackframe has source code context
@ogupte ogupte mentioned this issue Nov 30, 2018
Merged
ogupte added a commit to ogupte/kibana that referenced this issue Dec 3, 2018
@ogupte
[APM] fixes elastic#23560 by separating frame headers from code previ…
cdffea2 
…ew and only displaying code preview when stackframe has source code context
ogupte added a commit to ogupte/kibana that referenced this issue Dec 4, 2018
@ogupte
[APM] fixes elastic#23560 by separating frame headers from code previ…
81d9255 
…ew and only displaying code preview when stackframe has source code context
ogupte added a commit that referenced this issue Dec 4, 2018
@ogupte
[APM] Stacktrace heading styles (#26456)
754aa25 
* [APM] fixes #23560 by separating frame headers from code preview and only displaying code preview when stackframe has source code context

* [APM] fixes #26239 by checking for valid line number before displaying it

* [APM] Converted CodePreview and Stacktace to typescript and consolidated Stackframe types

* [APM] pull out components and util functions into own files and added tests
ogupte added a commit to ogupte/kibana that referenced this issue Dec 4, 2018
@ogupte
[APM] Stacktrace heading styles (elastic#26456)
b1e3e93 
* [APM] fixes elastic#23560 by separating frame headers from code preview and only displaying code preview when stackframe has source code context

* [APM] fixes elastic#26239 by checking for valid line number before displaying it

* [APM] Converted CodePreview and Stacktace to typescript and consolidated Stackframe types

* [APM] pull out components and util functions into own files and added tests
ogupte added a commit that referenced this issue Dec 5, 2018
@ogupte
[APM] Stacktrace heading styles (#26456) (#26668)
a0cc018 
* [APM] fixes #23560 by separating frame headers from code preview and only displaying code preview when stackframe has source code context

* [APM] fixes #26239 by checking for valid line number before displaying it

* [APM] Converted CodePreview and Stacktace to typescript and consolidated Stackframe types

* [APM] pull out components and util functions into own files and added tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ogupte ogupte

Labels
Team:APM All issues that need APM UI Team support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sorenlouv @ogupte @formgeist @elasticmachine @alvarolobato