-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Unified search] Consider not clearing the value on the filter builder when the operator changes #156842
Comments
Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations) |
cc @MichaelMarcialis @andreadelrio how do you feel about it? |
Clarification: They should only preserve if they are compatible, for example is -> is not, but not is between -> is |
Makes sense to me to keep the value if its compatible with the operator. Am I correct in assuming that changing a field will still reset the operator and value? |
Correct! |
+1 for me on this change. I seem to remember users found this annoying in the small usability testing we conducted in Dec 2022. |
…e operator changes (#176911) ## Summary Fixes #156842 Here's the table with how we transform/clear/preserve values: <img width="1127" alt="Screenshot 2024-02-14 at 17 17 36" src="https://github.com/elastic/kibana/assets/4283304/1ee878d5-8734-4143-9d1c-e7f0399c0eaf"> https://github.com/elastic/kibana/assets/4283304/0fccf3a9-a8fd-485b-b252-b9e3845ca9da
…e operator changes (elastic#176911) ## Summary Fixes elastic#156842 Here's the table with how we transform/clear/preserve values: <img width="1127" alt="Screenshot 2024-02-14 at 17 17 36" src="https://github.com/elastic/kibana/assets/4283304/1ee878d5-8734-4143-9d1c-e7f0399c0eaf"> https://github.com/elastic/kibana/assets/4283304/0fccf3a9-a8fd-485b-b252-b9e3845ca9da
…e operator changes (elastic#176911) ## Summary Fixes elastic#156842 Here's the table with how we transform/clear/preserve values: <img width="1127" alt="Screenshot 2024-02-14 at 17 17 36" src="https://github.com/elastic/kibana/assets/4283304/1ee878d5-8734-4143-9d1c-e7f0399c0eaf"> https://github.com/elastic/kibana/assets/4283304/0fccf3a9-a8fd-485b-b252-b9e3845ca9da
…e operator changes (elastic#176911) ## Summary Fixes elastic#156842 Here's the table with how we transform/clear/preserve values: <img width="1127" alt="Screenshot 2024-02-14 at 17 17 36" src="https://github.com/elastic/kibana/assets/4283304/1ee878d5-8734-4143-9d1c-e7f0399c0eaf"> https://github.com/elastic/kibana/assets/4283304/0fccf3a9-a8fd-485b-b252-b9e3845ca9da
…e operator changes (elastic#176911) ## Summary Fixes elastic#156842 Here's the table with how we transform/clear/preserve values: <img width="1127" alt="Screenshot 2024-02-14 at 17 17 36" src="https://github.com/elastic/kibana/assets/4283304/1ee878d5-8734-4143-9d1c-e7f0399c0eaf"> https://github.com/elastic/kibana/assets/4283304/0fccf3a9-a8fd-485b-b252-b9e3845ca9da
Describe the feature:
Right now on the filter builder every time I change the operator, the value is also cleared. Although I do understand the value in this, I think that changing the many times the user might just want to select the reverted operator (if they have is, they want the is not). At this case is annoying to select the value again. Especially it is frustrating when:
I propose to not clear the values if the operator changes, if the user wants to clear them it is something easily done (comparing to have to select the same values again)
The text was updated successfully, but these errors were encountered: