Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unified search] Consider not clearing the value on the filter builder when the operator changes #156842

Closed
Tracked by #169986
stratoula opened this issue May 5, 2023 · 7 comments · Fixed by #176911
Closed
Tracked by #169986
Assignees
Labels
enhancement New value added to drive a business result Feature:Unified search Unified search related tasks impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure usability

Comments

@stratoula
Copy link
Contributor

Describe the feature:

Right now on the filter builder every time I change the operator, the value is also cleared. Although I do understand the value in this, I think that changing the many times the user might just want to select the reverted operator (if they have is, they want the is not). At this case is annoying to select the value again. Especially it is frustrating when:

  • you have a big list of fields
  • you have an array of values (is one of operator) and you have to reselect them

2

I propose to not clear the values if the operator changes, if the user wants to clear them it is something easily done (comparing to have to select the same values again)

@stratoula stratoula added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Feature:Unified search Unified search related tasks labels May 5, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@stratoula
Copy link
Contributor Author

cc @MichaelMarcialis @andreadelrio how do you feel about it?

@stratoula stratoula added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Jun 1, 2023
@stratoula
Copy link
Contributor Author

Clarification:

They should only preserve if they are compatible, for example is -> is not, but not is between -> is
Consider for multivalues to one value to keep only the first option.

@MichaelMarcialis
Copy link
Contributor

cc @MichaelMarcialis @andreadelrio how do you feel about it?

Makes sense to me to keep the value if its compatible with the operator. Am I correct in assuming that changing a field will still reset the operator and value?

@stratoula
Copy link
Contributor Author

Am I correct in assuming that changing a field will still reset the operator and value?

Correct!

@andreadelrio
Copy link
Contributor

+1 for me on this change. I seem to remember users found this annoying in the small usability testing we conducted in Dec 2022.

@mbondyra
Copy link
Contributor

mbondyra commented Feb 14, 2024

Here's the table with how we're going to transform/clear/preserve values:
Screenshot 2024-02-14 at 17 17 36

mbondyra added a commit that referenced this issue Feb 15, 2024
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
awahab07 pushed a commit to awahab07/kibana that referenced this issue Feb 19, 2024
fkanout pushed a commit to fkanout/kibana that referenced this issue Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Unified search Unified search related tasks impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure usability
Projects
None yet
6 participants