Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document advanced settings API #14873

Closed
tylersmalley opened this issue Nov 9, 2017 · 8 comments
Closed

Document advanced settings API #14873

tylersmalley opened this issue Nov 9, 2017 · 8 comments
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Docs

Comments

@tylersmalley
Copy link
Contributor

We should add documentation for this API and tag experimental.

@epixa
Copy link
Contributor

epixa commented May 29, 2018

What is the advanced setting API versus the saved object API?

@tylersmalley
Copy link
Contributor Author

tylersmalley commented May 30, 2018

@epixa this is the API used for the advanced settings in the UI.

I usually direct folks to inspect the request made by using the UI.

POST http://localhost:5601/api/kibana/settings
{"changes":{"defaultIndex":"logstash-*"}}

@epixa
Copy link
Contributor

epixa commented Jun 16, 2018

I'm not sure if this is really an API we want to expose to people. The whole changes thing would be completely unprecedented, not RESTful, and not how we'd design this API if our intention was for people to consume it. People can use the documented saved object APIs for config as a whole, and we can build a REST api specifically for updating individual advanced settings if we want.

@epixa epixa added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Aug 8, 2018
@gchaps
Copy link
Contributor

gchaps commented Sep 24, 2019

@epixa Do we have a decision on whether we are going to document this API? If not, can we close this issue?

@epixa
Copy link
Contributor

epixa commented Sep 25, 2019

I don't think we can reasonably encourage any person to use these APIs directly as they are today. I propose we add an issue for a proper settings API. @joshdover do you agree?

@joshdover
Copy link
Contributor

Agreed. If anything, we should just point users to the SavedObjects API in the meantime since that can be used as well (only tricky part is the object ID is the Kibana version number).

@cwurm
Copy link
Contributor

cwurm commented Nov 25, 2019

How would the SavedObjects API be used to change an Advanced Setting (e.g. to change siem:defaultIndex as asked in #51454)?

@tsullivan
Copy link
Member

Would the Saved Objects API be able to validate user inputs of the settings, for example check that dateFormat:tz is set to a valid time zone, as asked in #58437

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Docs
Projects
None yet
Development

No branches or pull requests

6 participants