Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Large dashboard layout screen capture contains glitch #138812

Open
jeramysoucy opened this issue Aug 15, 2022 · 3 comments
Open

Large dashboard layout screen capture contains glitch #138812

jeramysoucy opened this issue Aug 15, 2022 · 3 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Reporting:Screenshot Reporting issues pertaining to PNG/PDF file export old Used to help sort old issues on GH Projects which don't support the Created search term. SharedUX/fix-it-week Bugs that have been groomed and queued up for the team's next fix it week Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) test

Comments

@jeramysoucy
Copy link
Contributor

**Kibana version: 8.3

In my work on #137214 I found that the screen capture for the 'large_dashboard_preserve_layout' test contained a glitch - a large empty band of space running vertically through the image. This test still passes due to the test tolerance of 9% (#138810), which is likely why the glitch had not been noticed.

The glitch only seems to occur when the capture is generated by CI - I could not reproduce the issue locally.

x-pack/test/functional/apps/dashboard/group3/reporting/screenshots.ts

large_dashboard_preserve_layout_actual
@jeramysoucy jeramysoucy added bug Fixes for quality problems that affect the customer experience test Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Aug 15, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@jeramysoucy jeramysoucy mentioned this issue Aug 15, 2022
Closed
@nreese nreese added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) and removed Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Mar 23, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@tsullivan tsullivan mentioned this issue May 1, 2023
Closed
@tsullivan
Copy link
Member

tsullivan commented May 1, 2023 •
edited
Loading

The solution I propose is to take smaller screenshots at a time by dividing the capture area into a grid. The older implementation of PDF reports actually had that, but it was removed.

@tsullivan tsullivan mentioned this issue May 3, 2023
Merged
This was referenced May 15, 2023
Closed
Closed
Closed
Closed
@tsullivan tsullivan mentioned this issue Aug 15, 2023
Merged
@hp0620 hp0620 mentioned this issue Sep 15, 2023
Closed
@petrklapka petrklapka added the SharedUX/fix-it-week Bugs that have been groomed and queued up for the team's next fix it week label Jul 18, 2024
@tsullivan tsullivan added Feature:Reporting:Screenshot Reporting issues pertaining to PNG/PDF file export and removed (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead labels Aug 1, 2024
@petrklapka petrklapka added the old Used to help sort old issues on GH Projects which don't support the Created search term. label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Reporting:Screenshot Reporting issues pertaining to PNG/PDF file export old Used to help sort old issues on GH Projects which don't support the Created search term. SharedUX/fix-it-week Bugs that have been groomed and queued up for the team's next fix it week Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nreese @tsullivan @elasticmachine @petrklapka @jeramysoucy