Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide how to handle tests and linting in core plugins #13799

Closed
kimjoar opened this issue Aug 31, 2017 · 1 comment
Closed

Decide how to handle tests and linting in core plugins #13799

kimjoar opened this issue Aug 31, 2017 · 1 comment
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@kimjoar
Copy link
Contributor

kimjoar commented Aug 31, 2017

Extension of #12467

We need to decide how to test and lint core plugins. I think we should just have a single test and linting setup for the entire Kibana repo, instead of having separate configs. Then external plugins can do whatever they want for testing.

However, for integration testing likely need something that external plugins can hook into. See #12699 for the integration test issue.

If we decide on going this route, I think this likely works out of the box with the current Jest setup, we just need to make sure.

@kimjoar kimjoar added Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Aug 31, 2017
@epixa
Copy link
Contributor

epixa commented May 5, 2018

I'm going to close this for now. It's likely we will need to do this, but we can create an issue for this if/when we do that has more details. I'm not keen on keeping new platform issues around that aren't concrete tasks, at least for now.

@epixa epixa closed this as completed May 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

2 participants