Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests for new platform #12699

Closed
7 of 13 tasks
kimjoar opened this issue Jul 7, 2017 · 4 comments
Closed
7 of 13 tasks

Integration tests for new platform #12699

kimjoar opened this issue Jul 7, 2017 · 4 comments
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@kimjoar
Copy link
Contributor

kimjoar commented Jul 7, 2017

The new platform is currently only running unit tests. We need to look at getting a good setup for integration tests.

At this point we could work to merge up the new platform (because http server would be tested)

  • Write integration tests for new platform
  • Change kibana to have a single set of functional test scripts that by default executes OSS & x-pack tests. It should fall back to oss-only tests if a flag is passed.

Improvements to @kbn/test:

Future:

Historical:

(now outdated) Some ideas in a gist

@kimjoar kimjoar added Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Jul 7, 2017
@rhoboat
Copy link

rhoboat commented Mar 4, 2018

The purpose is to establish confidence in the new platform http server changes. Before merging that new platform http server, create these tests, for each type of kibana setup:

  • with and without base-path set
  • with and without https

Just need one test case for each thing, like a smoke test.

@rhoboat
Copy link

rhoboat commented Mar 4, 2018

- integration-tests
  - http
    - with-basepath
      - config
         - kibana/kibana.yml (plus other files)
         - elasticsearch/elasticsearch.yml (plus other files)
    - without-basepath
    - with-ssl

running:

node scripts/ftr --config=integration_tests/http/with-basepath

make the test runner able to start both kibana and es with what's inside config

@rhoboat
Copy link

rhoboat commented Mar 4, 2018

Running:

node scripts/ftr --config=integration_tests/config.js  # config.js requires all top level index.js files
  • each index.js references a test suite or bunch of test suites
  • each test suite has a beforeAll that starts up kibana and elasticsearch with the ymls in the local directory

@kimjoar
Copy link
Contributor Author

kimjoar commented Mar 8, 2018

The approach we discussed for this was starting with extracting the proc_runner from x-pack into a package in Kibana (maybe ./packages/kbn-proc-runner?)

@rhoboat rhoboat self-assigned this Mar 8, 2018
@rhoboat rhoboat changed the title Integration test setup for new platform Integration tests for new platform Jun 29, 2018
@epixa epixa closed this as completed Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

3 participants