Clean up

elastic · May 3, 2023 · fba01b5 · fba01b5
1 parent 2fd11d5
commit fba01b5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/src/plugins/embeddable/public/lib/attribute_service/attribute_service.tsx b/src/plugins/embeddable/public/lib/attribute_service/attribute_service.tsx
@@ -137,13 +137,12 @@ export class AttributeService<
       return input as ValType;
     }
     const { attributes } = await this.unwrapAttributes(input);
-    const libraryTitle = attributes.title;
     const { savedObjectId, ...originalInputToPropagate } = input;
+
     return {
       ...originalInputToPropagate,
       // by value visualizations should not have default titles and/or descriptions
       ...{ attributes: omit(attributes, ['title', 'description']) },
-      title: input.title ?? libraryTitle,
     } as unknown as ValType;
   };
 

diff --git a/test/functional/page_objects/dashboard_page.ts b/test/functional/page_objects/dashboard_page.ts
@@ -591,11 +591,7 @@ export class DashboardPageObject extends FtrService {
   public async getPanelTitles() {
     this.log.debug('in getPanelTitles');
     const titleObjects = await this.find.allByCssSelector('span.embPanel__titleInner');
-    const titles = await Promise.all(
-      titleObjects.map(async (title) => await title.getVisibleText())
-    );
-    this.log.debug('panel titles:', titles);
-    return titles;
+    return await Promise.all(titleObjects.map(async (title) => await title.getVisibleText()));
   }
 
   /**