Sorted out title issue

elastic · Aug 12, 2020 · ed0cb93 · ed0cb93
1 parent 3586923
commit ed0cb93
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/examples/embeddable_examples/public/book/book_embeddable.tsx b/examples/embeddable_examples/public/book/book_embeddable.tsx
@@ -127,6 +127,10 @@ export class BookEmbeddable extends Embeddable<BookEmbeddableInput, BookEmbeddab
     });
   }
 
+  public getTitle() {
+    return this.getOutput()?.title || this.getOutput().attributes?.title;
+  }
+
   public destroy() {
     super.destroy();
     this.subscription.unsubscribe();

diff --git a/src/plugins/dashboard/public/attribute_service/attribute_service.tsx b/src/plugins/dashboard/public/attribute_service/attribute_service.tsx
@@ -45,7 +45,7 @@ import {
  * into an embeddable input shape that contains that saved object's attributes by value.
  */
 export class AttributeService<
-  SavedObjectAttributes,
+  SavedObjectAttributes extends { title: string },
   ValType extends EmbeddableInput & { attributes: SavedObjectAttributes },
   RefType extends SavedObjectEmbeddableInput
 > {
@@ -128,10 +128,9 @@ export class AttributeService<
     return new Promise<RefType>((resolve, reject) => {
       const onSave = async (props: OnSaveProps): Promise<SaveResult> => {
         try {
+          input.attributes.title = props.newTitle;
           const wrappedInput = (await this.wrapAttributes(input.attributes, true)) as RefType;
-          wrappedInput.title = props.newTitle;
           resolve(wrappedInput);
-          throw new Error();
           return { id: wrappedInput.savedObjectId };
         } catch (error) {
           reject();
@@ -144,7 +143,7 @@ export class AttributeService<
           <SavedObjectSaveModal
             onSave={onSave}
             onClose={() => reject()}
-            title={input.title || ''}
+            title={input.attributes.title}
             showCopyOnSave={false}
             objectType={this.type}
             showDescription={false}

diff --git a/src/plugins/dashboard/public/plugin.tsx b/src/plugins/dashboard/public/plugin.tsx
@@ -139,7 +139,7 @@ export interface DashboardStart {
   dashboardFeatureFlagConfig: DashboardFeatureFlagConfig;
   DashboardContainerByValueRenderer: ReturnType<typeof createDashboardContainerByValueRenderer>;
   getAttributeService: <
-    A,
+    A extends { title: string },
     V extends EmbeddableInput & { attributes: A },
     R extends SavedObjectEmbeddableInput
   >(