remove fluff

elastic · Feb 24, 2021 · d0ac0bb · d0ac0bb
1 parent f886eed
commit d0ac0bb
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 11 deletions.
diff --git a/x-pack/plugins/reporting/common/schema_utils.ts b/x-pack/plugins/reporting/common/schema_utils.ts
@@ -20,13 +20,6 @@ export const durationToNumber = (value: number | moment.Duration): number => {
   return value.asMilliseconds();
 };
 
-export const numberToDuration = (value: number | moment.Duration): moment.Duration => {
-  if (typeof value === 'number') {
-    return moment.duration(value, 'milliseconds');
-  }
-  return value;
-};
-
 export const byteSizeValueToNumber = (value: number | ByteSizeValue) => {
   if (typeof value === 'number') {
     return value;

diff --git a/x-pack/plugins/reporting/server/core.ts b/x-pack/plugins/reporting/server/core.ts
@@ -68,7 +68,7 @@ export class ReportingCore {
   /*
    * Register startDeps
    */
-  public async pluginStart(startDeps: ReportingInternalStart) {
+  public pluginStart(startDeps: ReportingInternalStart) {
     this.pluginStart$.next(startDeps); // trigger the observer
     this.pluginStartDeps = startDeps; // cache
   }

diff --git a/x-pack/plugins/reporting/server/plugin.test.ts b/x-pack/plugins/reporting/server/plugin.test.ts
@@ -16,9 +16,9 @@ jest.mock('./browsers/install', () => ({
 }));
 
 import { coreMock } from 'src/core/server/mocks';
-import { featuresPluginMock } from '../../features/server/mocks';
 import { ReportingPlugin } from './plugin';
 import { createMockConfigSchema } from './test_helpers';
+import { featuresPluginMock } from '../../features/server/mocks';
 
 const sleep = (time: number) => new Promise((r) => setTimeout(r, time));
 

diff --git a/x-pack/plugins/reporting/server/plugin.ts b/x-pack/plugins/reporting/server/plugin.ts
@@ -29,8 +29,8 @@ export class ReportingPlugin
 
   constructor(context: PluginInitializerContext<ReportingConfigType>) {
     this.logger = new LevelLogger(context.logger.get());
-    this.reportingCore = new ReportingCore(this.logger);
     this.initializerContext = context;
+    this.reportingCore = new ReportingCore(this.logger);
   }
 
   public setup(core: CoreSetup, plugins: ReportingSetupDeps) {
@@ -117,7 +117,7 @@ export class ReportingPlugin
       const store = new ReportingStore(reportingCore, logger);
       const esqueue = await createQueueFactory(reportingCore, store, logger); // starts polling for pending jobs
 
-      await reportingCore.pluginStart({
+      reportingCore.pluginStart({
         browserDriverFactory,
         savedObjects: core.savedObjects,
         uiSettings: core.uiSettings,