review feedback

x-pack/plugins/ui_actions_enhanced/.eslintrc.json

@@ -0,0 +1,5 @@
+{
+  "rules": {
+    "@typescript-eslint/consistent-type-definitions": 0
+  }
+}

x-pack/plugins/ui_actions_enhanced/common/types.ts

@@ -0,0 +1,28 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+import { SerializableState } from '../../../../src/plugins/kibana_utils/common';
+
+export type BaseActionConfig = SerializableState;
+
+export type SerializedAction<Config extends BaseActionConfig = BaseActionConfig> = {
+  readonly factoryId: string;
+  readonly name: string;
+  readonly config: Config;
+};
+
+/**
+ * Serialized representation of a triggers-action pair, used to persist in storage.
+ */
+export type SerializedEvent = {
+  eventId: string;
+  triggers: string[];
+  action: SerializedAction;
+};
+
+export type DynamicActionsState = {
+  events: SerializedEvent[];
+};

x-pack/plugins/ui_actions_enhanced/public/components/action_wizard/test_data.tsx

@@ -24,7 +24,6 @@ export const dashboards = [
   { id: 'dashboard2', title: 'Dashboard 2' },
 ];
 
-// eslint-disable-next-line @typescript-eslint/consistent-type-definitions
 type DashboardDrilldownConfig = {
   dashboardId?: string;
   useCurrentFilters: boolean;
@@ -120,7 +119,6 @@ export const dashboardFactory = new ActionFactory(dashboardDrilldownActionFactor
   getFeatureUsageStart: () => licensingMock.createStart().featureUsage,
 });
 
-// eslint-disable-next-line @typescript-eslint/consistent-type-definitions
 type UrlDrilldownConfig = {
   url: string;
   openInNewTab: boolean;

x-pack/plugins/ui_actions_enhanced/public/dynamic_actions/types.ts

@@ -5,26 +5,9 @@
  */
 
 import { TriggerId } from '../../../../../src/plugins/ui_actions/public';
-import { SerializableState } from '../../../../../src/plugins/kibana_utils/common';
+import { SerializedAction, SerializedEvent, BaseActionConfig } from '../../common/types';
 
-export type BaseActionConfig = SerializableState;
-
-// eslint-disable-next-line @typescript-eslint/consistent-type-definitions
-export type SerializedAction<Config extends BaseActionConfig = BaseActionConfig> = {
-  readonly factoryId: string;
-  readonly name: string;
-  readonly config: Config;
-};
-
-/**
- * Serialized representation of a triggers-action pair, used to persist in storage.
- */
-// eslint-disable-next-line @typescript-eslint/consistent-type-definitions
-export type SerializedEvent = {
-  eventId: string;
-  triggers: string[];
-  action: SerializedAction;
-};
+export { SerializedAction, SerializedEvent, BaseActionConfig };
 
 /**
  * Action factory context passed into ActionFactories' CollectConfig, getDisplayName, getIconType

x-pack/plugins/ui_actions_enhanced/public/services/ui_actions_service_enhancements.ts

@@ -19,10 +19,9 @@ import { LicensingPluginSetup, LicensingPluginStart } from '../../../licensing/p
 import { SavedObjectReference } from '../../../../../src/core/types';
 import { PersistableStateDefinition } from '../../../../../src/plugins/kibana_utils/common';
 
-// eslint-disable-next-line @typescript-eslint/consistent-type-definitions
-export type DynamicActionsState = {
-  events: SerializedEvent[];
-};
+import { DynamicActionsState } from '../../common/types';
+
+export { DynamicActionsState };
 
 export interface UiActionsServiceEnhancementsParams {
   readonly actionFactories?: ActionFactoryRegistry;

x-pack/plugins/ui_actions_enhanced/public/test_helpers/time_range_container.ts

@@ -17,7 +17,6 @@ import { TimeRange } from '../../../../../src/plugins/data/public';
  * https://github.com/microsoft/TypeScript/issues/15300 is fixed so we use a type
  * here instead
  */
-// eslint-disable-next-line @typescript-eslint/consistent-type-definitions
 export type InheritedChildrenInput = {
   timeRange: TimeRange;
   id?: string;

x-pack/plugins/ui_actions_enhanced/server/index.ts

@@ -22,3 +22,10 @@ export {
   SerializedAction as UiActionsEnhancedSerializedAction,
   SerializedEvent as UiActionsEnhancedSerializedEvent,
 } from './types';
+
+export {
+  DynamicActionsState,
+  BaseActionConfig as UiActionsEnhancedBaseActionConfig,
+  SerializedAction as UiActionsEnhancedSerializedAction,
+  SerializedEvent as UiActionsEnhancedSerializedEvent,
+} from '../common/types';

x-pack/plugins/ui_actions_enhanced/server/types.ts

@@ -7,30 +7,9 @@
 import {
   PersistableState,
   PersistableStateDefinition,
-  SerializableState,
 } from '../../../../src/plugins/kibana_utils/common';
 
-// eslint-disable-next-line @typescript-eslint/consistent-type-definitions
-export type SerializedAction<Config extends SerializableState = SerializableState> = {
-  readonly factoryId: string;
-  readonly name: string;
-  readonly config: Config;
-};
-
-/**
- * Serialized representation of a triggers-action pair, used to persist in storage.
- */
-// eslint-disable-next-line @typescript-eslint/consistent-type-definitions
-export type SerializedEvent = {
-  eventId: string;
-  triggers: string[];
-  action: SerializedAction;
-};
-
-// eslint-disable-next-line @typescript-eslint/consistent-type-definitions
-export type DynamicActionsState = {
-  events: SerializedEvent[];
-};
+import { SerializedAction, SerializedEvent, DynamicActionsState } from '../common/types';
 
 export type ActionFactoryRegistry = Map<string, ActionFactory>;
 
@@ -43,3 +22,5 @@ export interface ActionFactory<P extends SerializedEvent = SerializedEvent>
   extends PersistableState<P> {
   id: string;
 }
+
+export { SerializedEvent, SerializedAction, DynamicActionsState };