Removed optional parameter and fixed tests to operate with it _not_ o…

…ptional
elastic · Jun 4, 2021 · b301d84 · b301d84
1 parent f68ae9b
commit b301d84
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/x-pack/plugins/security_solution/server/lib/detection_engine/signals/build_events_query.ts b/x-pack/plugins/security_solution/server/lib/detection_engine/signals/build_events_query.ts
@@ -17,7 +17,7 @@ interface BuildEventsSearchQuery {
   index: string[];
   from: string;
   to: string;
-  filter?: estypes.QueryContainer;
+  filter: estypes.QueryContainer;
   size: number;
   sortOrder?: SortOrderOrUndefined;
   searchAfterSortIds: SortResults | undefined;
@@ -94,8 +94,6 @@ export const buildEventsSearchQuery = ({
         ];
 
   const filterWithTime: estypes.QueryContainer[] = [
-    // but tests contain undefined, so I suppose it's desired behavior
-    // @ts-expect-error undefined in not assignable to QueryContainer
     filter,
     { bool: { filter: [{ bool: { should: [...rangeFilter], minimum_should_match: 1 } }] } },
   ];

diff --git a/...plugins/security_solution/server/lib/detection_engine/signals/single_search_after.test.ts b/...plugins/security_solution/server/lib/detection_engine/signals/single_search_after.test.ts
@@ -41,7 +41,7 @@ describe('singleSearchAfter', () => {
       services: mockService,
       logger: mockLogger,
       pageSize: 1,
-      filter: undefined,
+      filter: {},
       timestampOverride: undefined,
       buildRuleMessage,
     });
@@ -59,7 +59,7 @@ describe('singleSearchAfter', () => {
       services: mockService,
       logger: mockLogger,
       pageSize: 1,
-      filter: undefined,
+      filter: {},
       timestampOverride: undefined,
       buildRuleMessage,
     });
@@ -109,7 +109,7 @@ describe('singleSearchAfter', () => {
       services: mockService,
       logger: mockLogger,
       pageSize: 1,
-      filter: undefined,
+      filter: {},
       timestampOverride: undefined,
       buildRuleMessage,
     });
@@ -132,7 +132,7 @@ describe('singleSearchAfter', () => {
       services: mockService,
       logger: mockLogger,
       pageSize: 1,
-      filter: undefined,
+      filter: {},
       timestampOverride: undefined,
       buildRuleMessage,
     });
@@ -152,7 +152,7 @@ describe('singleSearchAfter', () => {
         services: mockService,
         logger: mockLogger,
         pageSize: 1,
-        filter: undefined,
+        filter: {},
         timestampOverride: undefined,
         buildRuleMessage,
       })

diff --git a/x-pack/plugins/security_solution/server/lib/detection_engine/signals/single_search_after.ts b/x-pack/plugins/security_solution/server/lib/detection_engine/signals/single_search_after.ts
@@ -32,7 +32,7 @@ interface SingleSearchAfterParams {
   logger: Logger;
   pageSize: number;
   sortOrder?: SortOrderOrUndefined;
-  filter?: estypes.QueryContainer;
+  filter: estypes.QueryContainer;
   timestampOverride: TimestampOverrideOrUndefined;
   buildRuleMessage: BuildRuleMessage;
 }