scroll ML page to fix test

elastic · Jun 29, 2021 · 58a1177 · 58a1177
1 parent 34f8ae7
commit 58a1177
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/test/functional/services/common/test_subjects.ts b/test/functional/services/common/test_subjects.ts
@@ -312,9 +312,12 @@ export class TestSubjects extends FtrService {
     return testSubjSelector(selector);
   }
 
-  public async scrollIntoView(selector: string) {
+  public async scrollIntoView(
+    selector: string,
+    offset: number | { topOffset?: number; bottomOffset?: number }
+  ) {
     const element = await this.find(selector);
-    await element.scrollIntoViewIfNecessary();
+    await element.scrollIntoViewIfNecessary(offset);
   }
 
   // isChecked always returns false when run on an euiSwitch, because they use the aria-checked attribute

diff --git a/x-pack/test/functional/services/ml/data_visualizer_file_based.ts b/x-pack/test/functional/services/ml/data_visualizer_file_based.ts
@@ -10,6 +10,8 @@ import expect from '@kbn/expect';
 import { FtrProviderContext } from '../../ftr_provider_context';
 import { MlCommonUI } from './common_ui';
 
+const fixedFooterHeight = 72; // Size of EuiBottomBar more or less
+
 export function MachineLearningDataVisualizerFileBasedProvider(
   { getService, getPageObjects }: FtrProviderContext,
   mlCommonUI: MlCommonUI
@@ -131,7 +133,9 @@ export function MachineLearningDataVisualizerFileBasedProvider(
     },
 
     async selectCreateFilebeatConfig() {
-      await testSubjects.scrollIntoView('fileDataVisFilebeatConfigLink');
+      await testSubjects.scrollIntoView('fileDataVisFilebeatConfigLink', {
+        bottomOffset: fixedFooterHeight,
+      });
       await testSubjects.click('fileDataVisFilebeatConfigLink');
       await testSubjects.existOrFail('fileDataVisFilebeatConfigPanel');
     },