[SIEM] Add eslint-plugin-react-perf (#55960) (#56729)

elastic · Feb 4, 2020 · 58536f8 · 58536f8
1 parent e5a0477
commit 58536f8
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 2 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -647,6 +647,18 @@ module.exports = {
         // '@typescript-eslint/unbound-method': 'error',
       },
     },
+    // {
+    //   // will introduced after the other warns are fixed
+    //   // typescript and javascript for front end react performance
+    //   files: ['x-pack/legacy/plugins/siem/public/**/!(*.test).{js,ts,tsx}'],
+    //   plugins: ['react-perf'],
+    //   rules: {
+    //     // 'react-perf/jsx-no-new-object-as-prop': 'error',
+    //     // 'react-perf/jsx-no-new-array-as-prop': 'error',
+    //     // 'react-perf/jsx-no-new-function-as-prop': 'error',
+    //     // 'react/jsx-no-bind': 'error',
+    //   },
+    // },
     {
       // typescript and javascript for front and back end
       files: ['x-pack/legacy/plugins/siem/**/*.{js,ts,tsx}'],
@@ -751,8 +763,6 @@ module.exports = {
         // will introduced after the other warns are fixed
         // 'react/sort-comp': 'error',
         'react/void-dom-elements-no-children': 'error',
-        // will introduced after the other warns are fixed
-        // 'react/jsx-no-bind': 'error',
         'react/jsx-no-comment-textnodes': 'error',
         'react/jsx-no-literals': 'error',
         'react/jsx-no-target-blank': 'error',

diff --git a/package.json b/package.json
@@ -408,6 +408,7 @@
     "eslint-plugin-prettier": "^3.1.2",
     "eslint-plugin-react": "^7.17.0",
     "eslint-plugin-react-hooks": "^2.3.0",
+    "eslint-plugin-react-perf": "^3.2.3",
     "exit-hook": "^2.2.0",
     "faker": "1.1.0",
     "fetch-mock": "^7.3.9",

diff --git a/yarn.lock b/yarn.lock
@@ -13277,6 +13277,11 @@ eslint-plugin-react-hooks@^2.3.0:
   resolved "https://registry.yarnpkg.com/eslint-plugin-react-hooks/-/eslint-plugin-react-hooks-2.3.0.tgz#53e073961f1f5ccf8dd19558036c1fac8c29d99a"
   integrity sha512-gLKCa52G4ee7uXzdLiorca7JIQZPPXRAQDXV83J4bUEeUuc5pIEyZYAZ45Xnxe5IuupxEqHS+hUhSLIimK1EMw==
 
+eslint-plugin-react-perf@^3.2.3:
+  version "3.2.3"
+  resolved "https://registry.yarnpkg.com/eslint-plugin-react-perf/-/eslint-plugin-react-perf-3.2.3.tgz#e28d42d3a1f7ec3c8976a94735d8e17e7d652a45"
+  integrity sha512-bMiPt7uywwS1Ly25n752NE3Ei0XBZ3igplTkZ8GPJKyZVVUd3cHgzILGeQW2HIeAkzQ9zwk9HM6EcYDipdFk3Q==
+
 eslint-plugin-react@^7.17.0:
   version "7.17.0"
   resolved "https://registry.yarnpkg.com/eslint-plugin-react/-/eslint-plugin-react-7.17.0.tgz#a31b3e134b76046abe3cd278e7482bd35a1d12d7"