Adjusted use of 'setValue()' based on feedback from @dmlemeshko

elastic · Dec 13, 2021 · 4ee8a49 · 4ee8a49
1 parent 3fcd626
commit 4ee8a49
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/test/functional/services/common/test_subjects.ts b/test/functional/services/common/test_subjects.ts
@@ -206,8 +206,7 @@ export class TestSubjects extends FtrService {
       // call clearValue() and type() on the element that is focused after
       // clicking on the testSubject
       const input = await this.findService.activeElement();
-      // if `text` is explicitely set to the empty string, then call clearValueWithKeyboard() rather than clearValue()
-      if (clearWithKeyboard === true || text === '') {
+      if (clearWithKeyboard === true) {
         await input.clearValueWithKeyboard();
       } else {
         await input.clearValue();

diff --git a/test/functional/services/dashboard/panel_actions.ts b/test/functional/services/dashboard/panel_actions.ts
@@ -316,7 +316,9 @@ export class DashboardPanelActionsService extends FtrService {
     } else {
       await this.customizePanel();
     }
-    await this.testSubjects.setValue('customEmbeddablePanelTitleInput', customTitle);
+    await this.testSubjects.setValue('customEmbeddablePanelTitleInput', customTitle, {
+      clearWithKeyboard: customTitle === '', // if clearing the title using the empty string as the new value, 'clearWithKeyboard' must be true; otherwise, false
+    });
     await this.testSubjects.click('saveNewTitleButton');
   }