Skip to content

Commit

Permalink
[kbn/es] disable geoip downloader at the root (#98372)
Browse files Browse the repository at this point in the history
Co-authored-by: spalger <spalger@users.noreply.github.com>
  • Loading branch information
Spencer and spalger authored Apr 27, 2021
1 parent 0b16688 commit 3166041
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
7 changes: 5 additions & 2 deletions packages/kbn-es/src/cluster.js
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,10 @@ exports.Cluster = class Cluster {
this._log.info(chalk.bold('Starting'));
this._log.indent(4);

const esArgs = ['action.destructive_requires_name=true'].concat(options.esArgs || []);
const esArgs = [
'action.destructive_requires_name=true',
'ingest.geoip.downloader.enabled=false',
].concat(options.esArgs || []);

// Add to esArgs if ssl is enabled
if (this._ssl) {
Expand All @@ -272,7 +275,7 @@ exports.Cluster = class Cluster {
// especially because we currently run many instances of ES on the same machine during CI
options.esEnvVars.ES_JAVA_OPTS =
(options.esEnvVars.ES_JAVA_OPTS ? `${options.esEnvVars.ES_JAVA_OPTS} ` : '') +
'-Xms2g -Xmx2g';
'-Xms1g -Xmx1g';

this._process = execa(ES_BIN, args, {
cwd: installPath,
Expand Down
2 changes: 2 additions & 0 deletions packages/kbn-es/src/integration_tests/cluster.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,7 @@ describe('#start(installPath)', () => {
Array [
Array [
"action.destructive_requires_name=true",
"ingest.geoip.downloader.enabled=false",
],
undefined,
Object {
Expand Down Expand Up @@ -344,6 +345,7 @@ describe('#run()', () => {
Array [
Array [
"action.destructive_requires_name=true",
"ingest.geoip.downloader.enabled=false",
],
undefined,
Object {
Expand Down
2 changes: 1 addition & 1 deletion test/common/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export default function () {
servers,

esTestCluster: {
serverArgs: ['xpack.security.enabled=false', 'geoip.downloader.enabled=false'],
serverArgs: ['xpack.security.enabled=false'],
},

kbnTestServer: {
Expand Down

0 comments on commit 3166041

Please sign in to comment.