Skip to content

Commit

Permalink
[ML] Moving get filters capability to admin (#64879) (#64890)
Browse files Browse the repository at this point in the history 
* [ML] Moving get filters capability to admin

* updating test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
  • Loading branch information
@jgowdyelastic @elasticmachine
jgowdyelastic and elasticmachine authored May 4, 2020
1 parent c8e1efa commit 0887cac
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions x-pack/plugins/ml/common/types/capabilities.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ export const userMlCapabilities = {
canGetCalendars: false,
// File Data Visualizer
canFindFileStructure: false,
// Filters
canGetFilters: false,
// Data Frame Analytics
canGetDataFrameAnalytics: false,
// Annotations
Expand All @@ -38,6 +36,8 @@ export const adminMlCapabilities = {
canStartStopDatafeed: false,
canUpdateDatafeed: false,
canPreviewDatafeed: false,
// Filters
canGetFilters: false,
// Calendars
canCreateCalendar: false,
canDeleteCalendar: false,
Expand Down
12 changes: 6 additions & 6 deletions x-pack/plugins/ml/server/lib/capabilities/check_capabilities.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ describe('check_capabilities', () => {
expect(capabilities.canGetDatafeeds).toBe(true);
expect(capabilities.canGetCalendars).toBe(true);
expect(capabilities.canFindFileStructure).toBe(true);
expect(capabilities.canGetFilters).toBe(true);
expect(capabilities.canGetDataFrameAnalytics).toBe(true);
expect(capabilities.canGetAnnotations).toBe(true);
expect(capabilities.canCreateAnnotation).toBe(true);
Expand All @@ -81,6 +80,7 @@ describe('check_capabilities', () => {
expect(capabilities.canDeleteDatafeed).toBe(false);
expect(capabilities.canUpdateDatafeed).toBe(false);
expect(capabilities.canPreviewDatafeed).toBe(false);
expect(capabilities.canGetFilters).toBe(false);
expect(capabilities.canCreateCalendar).toBe(false);
expect(capabilities.canDeleteCalendar).toBe(false);
expect(capabilities.canCreateFilter).toBe(false);
Expand Down Expand Up @@ -113,7 +113,6 @@ describe('check_capabilities', () => {
expect(capabilities.canGetDatafeeds).toBe(true);
expect(capabilities.canGetCalendars).toBe(true);
expect(capabilities.canFindFileStructure).toBe(true);
expect(capabilities.canGetFilters).toBe(true);
expect(capabilities.canGetDataFrameAnalytics).toBe(true);
expect(capabilities.canGetAnnotations).toBe(true);
expect(capabilities.canCreateAnnotation).toBe(true);
Expand All @@ -130,6 +129,7 @@ describe('check_capabilities', () => {
expect(capabilities.canDeleteDatafeed).toBe(true);
expect(capabilities.canUpdateDatafeed).toBe(true);
expect(capabilities.canPreviewDatafeed).toBe(true);
expect(capabilities.canGetFilters).toBe(true);
expect(capabilities.canCreateCalendar).toBe(true);
expect(capabilities.canDeleteCalendar).toBe(true);
expect(capabilities.canCreateFilter).toBe(true);
Expand Down Expand Up @@ -162,7 +162,6 @@ describe('check_capabilities', () => {
expect(capabilities.canGetDatafeeds).toBe(true);
expect(capabilities.canGetCalendars).toBe(true);
expect(capabilities.canFindFileStructure).toBe(true);
expect(capabilities.canGetFilters).toBe(true);
expect(capabilities.canGetDataFrameAnalytics).toBe(true);
expect(capabilities.canGetAnnotations).toBe(true);
expect(capabilities.canCreateAnnotation).toBe(false);
Expand All @@ -177,6 +176,7 @@ describe('check_capabilities', () => {
expect(capabilities.canUpdateJob).toBe(false);
expect(capabilities.canCreateDatafeed).toBe(false);
expect(capabilities.canDeleteDatafeed).toBe(false);
expect(capabilities.canGetFilters).toBe(false);
expect(capabilities.canUpdateDatafeed).toBe(false);
expect(capabilities.canPreviewDatafeed).toBe(false);
expect(capabilities.canCreateCalendar).toBe(false);
Expand Down Expand Up @@ -211,7 +211,6 @@ describe('check_capabilities', () => {
expect(capabilities.canGetDatafeeds).toBe(true);
expect(capabilities.canGetCalendars).toBe(true);
expect(capabilities.canFindFileStructure).toBe(true);
expect(capabilities.canGetFilters).toBe(true);
expect(capabilities.canGetDataFrameAnalytics).toBe(true);
expect(capabilities.canGetAnnotations).toBe(true);
expect(capabilities.canCreateAnnotation).toBe(false);
Expand All @@ -228,6 +227,7 @@ describe('check_capabilities', () => {
expect(capabilities.canDeleteDatafeed).toBe(false);
expect(capabilities.canUpdateDatafeed).toBe(false);
expect(capabilities.canPreviewDatafeed).toBe(false);
expect(capabilities.canGetFilters).toBe(false);
expect(capabilities.canCreateCalendar).toBe(false);
expect(capabilities.canDeleteCalendar).toBe(false);
expect(capabilities.canCreateFilter).toBe(false);
Expand Down Expand Up @@ -260,7 +260,6 @@ describe('check_capabilities', () => {
expect(capabilities.canGetDatafeeds).toBe(false);
expect(capabilities.canGetCalendars).toBe(false);
expect(capabilities.canFindFileStructure).toBe(false);
expect(capabilities.canGetFilters).toBe(false);
expect(capabilities.canGetDataFrameAnalytics).toBe(false);
expect(capabilities.canGetAnnotations).toBe(false);
expect(capabilities.canCreateAnnotation).toBe(false);
Expand All @@ -277,6 +276,7 @@ describe('check_capabilities', () => {
expect(capabilities.canDeleteDatafeed).toBe(false);
expect(capabilities.canUpdateDatafeed).toBe(false);
expect(capabilities.canPreviewDatafeed).toBe(false);
expect(capabilities.canGetFilters).toBe(false);
expect(capabilities.canCreateCalendar).toBe(false);
expect(capabilities.canDeleteCalendar).toBe(false);
expect(capabilities.canCreateFilter).toBe(false);
Expand Down Expand Up @@ -311,7 +311,6 @@ describe('check_capabilities', () => {
expect(capabilities.canGetDatafeeds).toBe(false);
expect(capabilities.canGetCalendars).toBe(false);
expect(capabilities.canFindFileStructure).toBe(false);
expect(capabilities.canGetFilters).toBe(false);
expect(capabilities.canGetDataFrameAnalytics).toBe(false);
expect(capabilities.canGetAnnotations).toBe(false);
expect(capabilities.canCreateAnnotation).toBe(false);
Expand All @@ -328,6 +327,7 @@ describe('check_capabilities', () => {
expect(capabilities.canDeleteDatafeed).toBe(false);
expect(capabilities.canUpdateDatafeed).toBe(false);
expect(capabilities.canPreviewDatafeed).toBe(false);
expect(capabilities.canGetFilters).toBe(false);
expect(capabilities.canCreateCalendar).toBe(false);
expect(capabilities.canDeleteCalendar).toBe(false);
expect(capabilities.canCreateFilter).toBe(false);
Expand Down

0 comments on commit 0887cac

Please sign in to comment.