Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Documentation] Update TSDB guidelines to provide testing guidance #7679

Merged
merged 6 commits into from
Sep 12, 2023
Merged

[Documentation] Update TSDB guidelines to provide testing guidance #7679

merged 6 commits into from
Sep 12, 2023

Conversation

constanca-m
Copy link
Contributor

What does this PR do?

Changes:

  • The TSDB migration test kit is referenced in this kit.
  • Fix the steps order.

@constanca-m
Update TSDB guidelines.
85cfd1d 
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m requested a review from a team as a code owner September 6, 2023 15:22
@constanca-m constanca-m self-assigned this Sep 6, 2023
@constanca-m constanca-m added the documentation Improvements or additions to documentation label Sep 6, 2023
tetianakravchenko
tetianakravchenko reviewed Sep 6, 2023
View reviewed changes
docs/developer_tsdb_migration_guidelines.md Outdated Show resolved Hide resolved
docs/developer_tsdb_migration_guidelines.md
dimension: true
```

> **Note**: A field having type [flattened](https://www.elastic.co/guide/en/elasticsearch/reference/current/flattened.html) cannot be selected as a dimension field. If the field that you are choosing as a dimension is too long or is of type flattened, consider hashing the value of this field and using the result as a dimension. [Fingerprint processor](https://www.elastic.co/guide/en/elasticsearch/reference/current/fingerprint-processor.html) can be used for this purpose.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that flattened should be supported now - elastic/elasticsearch#94113 (comment), no ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure myself, need someone to check this.

docs/developer_tsdb_migration_guidelines.md Outdated Show resolved Hide resolved
constanca-m and others added 2 commits September 6, 2023 17:50
@constanca-m @tetianakravchenko
Update docs/developer_tsdb_migration_guidelines.md
69f0a82 
Co-authored-by: Tetiana Kravchenko <tanya.kravchenko.v@gmail.com>
@constanca-m @tetianakravchenko
Update docs/developer_tsdb_migration_guidelines.md
e8df130 
Co-authored-by: Tetiana Kravchenko <tanya.kravchenko.v@gmail.com>
@elasticmachine
Copy link

elasticmachine commented Sep 6, 2023 •
edited
Loading

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-11T11:53:17.986+0000

  • Duration: 112 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 4935
Skipped 10
Total 4945

Steps errors 4

Expand to view the steps failures

Test integration: akamai
  • Took 11 min 39 sec . View more details here
  • Description: eval "$(../../build/elastic-package stack shellinit)" ../../build/elastic-package test -v --report-format xUnit --report-output file --test-coverage
Test integration: prometheus_input
  • Took 11 min 43 sec . View more details here
  • Description: eval "$(../../build/elastic-package stack shellinit)" ../../build/elastic-package test -v --report-format xUnit --report-output file --test-coverage
Test integration: websphere_application_server
  • Took 11 min 45 sec . View more details here
  • Description: eval "$(../../build/elastic-package stack shellinit)" ../../build/elastic-package test -v --report-format xUnit --report-output file --test-coverage
Google Storage Download
  • Took 0 min 0 sec . View more details here

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 6, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (449/449) 💚
Files 96.633% (775/802) 👎 -3.367
Classes 96.633% (775/802) 👎 -3.367
Methods 92.247% (7532/8165) 👍 1.478
Lines 88.297% (171108/193787) 👍 0.004
Conditionals 100.0% (0/0) 💚

@constanca-m
Update TSDB guidelines.
464a74c 
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m
Update TSDB guidelines.
c6d5b78 
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m
Update TSDB guidelines.
901f275 
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
lalit-satapathy
lalit-satapathy approved these changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@lalit-satapathy lalit-satapathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@constanca-m
Copy link
Contributor Author

/test

@jsoriano jsoriano merged commit 1b7860f into elastic:main Sep 12, 2023
3 of 4 checks passed
@constanca-m constanca-m deleted the update-tsdb-documentation branch September 21, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tetianakravchenko tetianakravchenko tetianakravchenko left review comments

@lalit-satapathy lalit-satapathy lalit-satapathy approved these changes

Assignees

@constanca-m constanca-m

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@constanca-m @elasticmachine @tetianakravchenko @lalit-satapathy @jsoriano