-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AWS] Add dimensions to EC2 data stream. #7487
Conversation
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Out of curiosity: you didn't define cloud.instance.id
as a dimension because we already have aws.dimensions.InstanceId
, right?
🌐 Coverage report
|
Yes @zmoog, and to also keep the consistency on the |
Package aws - 1.53.4 containing this change is available at https://epr.elastic.co/search?package=aws |
* Add dimensions to EC2 data stream. Signed-off-by: constanca-m <constanca.manteigas@elastic.co> * Update changelog.yml Signed-off-by: constanca-m <constanca.manteigas@elastic.co> --------- Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
What does this PR do?
Set the dimension fields for EC2 data stream.
All
dimension.*
fields infields.yml
are dimensions.For the ecs fields, the reasoning for the fields can be found in this comment.
Result of successful testing:
Checklist
changelog.yml
file.Related issues
Relates to #6293.