Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS] Add dimensions to EC2 data stream. #7487

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

constanca-m
Copy link
Contributor

What does this PR do?

Set the dimension fields for EC2 data stream.

All dimension.* fields in fields.yml are dimensions.

For the ecs fields, the reasoning for the fields can be found in this comment.

Result of successful testing:

All 130 documents taken from index .ds-metrics-aws.ec2_metrics-default-2023.08.22-000001 were successfully placed to index tsdb-index-enabled.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Relates to #6293.

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m self-assigned this Aug 22, 2023
@constanca-m constanca-m requested review from a team as code owners August 22, 2023 07:32
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Out of curiosity: you didn't define cloud.instance.id as a dimension because we already have aws.dimensions.InstanceId, right?

@elasticmachine
Copy link

elasticmachine commented Aug 22, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-22T07:34:12.745+0000

  • Duration: 49 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 208
Skipped 4
Total 212

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 94.444% (17/18) 👎 -5.556
Classes 94.444% (17/18) 👎 -5.556
Methods 85.953% (257/299) 👎 -14.047
Lines 86.024% (7509/8729) 👎 -13.976
Conditionals 100.0% (0/0) 💚

@constanca-m
Copy link
Contributor Author

Out of curiosity: you didn't define cloud.instance.id as a dimension because we already have aws.dimensions.InstanceId, right?

Yes @zmoog, and to also keep the consistency on the ecs fields defined as dimension across the AWS data streams.

@constanca-m constanca-m merged commit 2eda5ac into elastic:main Aug 22, 2023
4 checks passed
@constanca-m constanca-m deleted the ec2-add-dimensions branch August 22, 2023 08:24
@elasticmachine
Copy link

Package aws - 1.53.4 containing this change is available at https://epr.elastic.co/search?package=aws

gizas pushed a commit that referenced this pull request Sep 5, 2023
* Add dimensions to EC2 data stream.

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>

* Update changelog.yml

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>

---------

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants