Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[System][Process] Add metric_type metadata for the process.cgroup metrics #6493

Merged
merged 3 commits into from
Jul 18, 2023
Merged

[System][Process] Add metric_type metadata for the process.cgroup metrics #6493

merged 3 commits into from
Jul 18, 2023

Conversation

tetianakravchenko
Copy link
Contributor

@tetianakravchenko tetianakravchenko commented Jun 6, 2023 •
edited
Loading

What does this PR do?

Add metric_type metadata fields to the process.cgroup metrics

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@tetianakravchenko
add metric_type metadata to the process.cgroup metrics
fa1f348 
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko tetianakravchenko changed the title [System][Process] Add metric_type metadata x the process.cgroup metrics [System][Process] Add metric_type metadata for the process.cgroup metrics Jun 6, 2023
@tetianakravchenko
merge main branch in, fix conflicts
e4fa8a2 
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@elasticmachine
Copy link

elasticmachine commented Jun 6, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-18T13:33:29.087+0000

  • Duration: 16 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 146
Skipped 0
Total 146

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 6, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 60.759% (48/79) 👎 -39.241
Lines 99.86% (2852/2856) 👍 8.935
Conditionals 100.0% (0/0) 💚

tetianakravchenko
tetianakravchenko commented Jun 7, 2023
View reviewed changes
Copy link
Contributor Author

@tetianakravchenko tetianakravchenko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: metric_type is missing for fields:

- name: stats.*.*.bytes
   type: object
   description: per-device IO usage stats
- name: stats.*.*.ios
   type: object
   description: per-device IO usage stats
  1. I am confused why are those values of type object:
Screenshot 2023-06-07 at 12 02 38

@elastic/elastic-agent-data-plane is it a mistake? should be changed?
2. I've tried to add metric_type, but package can't be updated to the new version in this case

The issue could be also related to elastic/kibana#155004

packages/system/data_stream/process/fields/fields.yml
description: Time the cgroup spent in kernel space, as a percentage of total CPU time
- name: stats.system.norm.pct
type: scaled_float
metric_type: gauge
description: Time the cgroup spent in kernel space, as a percentage of total CPU time, normalized by CPU count.
- name: percpu
type: object
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: metric_type is missing here, blocked by elastic/kibana#155004

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a backlog issue created and linked to the TSDB meta so that this pending mapping could be tracked?

@tetianakravchenko tetianakravchenko marked this pull request as ready for review June 7, 2023 10:17
@tetianakravchenko tetianakravchenko requested a review from a team as a code owner June 7, 2023 10:17
@tetianakravchenko tetianakravchenko mentioned this pull request Jun 7, 2023
Closed
11 tasks
agithomas
agithomas approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@botelastic
Copy link

botelastic bot commented Jul 7, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jul 7, 2023
@tetianakravchenko tetianakravchenko requested a review from a team as a code owner July 18, 2023 13:33
@botelastic botelastic bot removed the Stalled label Jul 18, 2023
@tetianakravchenko
Copy link
Contributor Author

tetianakravchenko commented Jul 18, 2023 •
edited
Loading

@agithomas FYI: I am going to merge this PR and work on #6493 (comment) in separate one

@tetianakravchenko tetianakravchenko merged commit 13a0efa into elastic:main Jul 18, 2023
1 check passed
@elasticmachine
Copy link

Package system - 1.37.1 containing this change is available at https://epr.elastic.co/search?package=system

@tetianakravchenko tetianakravchenko mentioned this pull request Sep 5, 2023
Merged
4 tasks
gizas pushed a commit that referenced this pull request Sep 5, 2023
@tetianakravchenko @gizas
add metric_type metadata to the process.cgroup metrics (#6493)
79ea018 
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agithomas agithomas agithomas approved these changes

@cmacknz cmacknz Awaiting requested review from cmacknz cmacknz was automatically assigned from elastic/elastic-agent-data-plane

@leehinman leehinman Awaiting requested review from leehinman leehinman was automatically assigned from elastic/elastic-agent-data-plane

Assignees
No one assigned
Labels
Integration:system System
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tetianakravchenko @elasticmachine @agithomas @andrewkroh