Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[system] support ip or domain in sshd messages #6256

Merged
merged 1 commit into from
May 25, 2023
Merged

[system] support ip or domain in sshd messages #6256

merged 1 commit into from
May 25, 2023

Conversation

leehinman
Copy link
Contributor

@leehinman leehinman commented May 18, 2023 •
edited
Loading

What does this PR do?

Adds support for ip or domain name in ssh messages in system integration

  • store original in source.address
  • convert to ip and store in source.ip
  • store in source.domain if ip conversion fails

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

elastic-package test

@leehinman
[system] support ip or domain in sshd messages
b5386a7 
- store original in source.address
- convert to ip and store in source.ip
- store in source.domain if ip conversion fails
@leehinman leehinman added enhancement New feature or request Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team [elastic/elastic-agent-data-plane] labels May 18, 2023
@elasticmachine
Copy link

elasticmachine commented May 18, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-18T16:47:44.996+0000

  • Duration: 15 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 145
Skipped 0
Total 145

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@leehinman leehinman marked this pull request as ready for review May 18, 2023 16:48
@leehinman leehinman requested a review from a team as a code owner May 18, 2023 16:48
@elasticmachine
Copy link

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 60.759% (48/79) ❕
Lines 99.536% (2790/2803) ❕
Conditionals 100.0% (0/0) 💚

bhapas
bhapas approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leehinman leehinman merged commit a9a2516 into elastic:main May 25, 2023
@elasticmachine
Copy link

Package system - 1.29.0 containing this change is available at https://epr.elastic.co/search?package=system

@leehinman leehinman mentioned this pull request May 25, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhapas bhapas bhapas approved these changes

@rdner rdner rdner approved these changes

@pierrehilbert pierrehilbert Awaiting requested review from pierrehilbert pierrehilbert was automatically assigned from elastic/elastic-agent-data-plane

@cmacknz cmacknz Awaiting requested review from cmacknz cmacknz was automatically assigned from elastic/elastic-agent-data-plane

Assignees
No one assigned
Labels
enhancement New feature or request Integration:system System Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team [elastic/elastic-agent-data-plane]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@leehinman @elasticmachine @rdner @bhapas @andrewkroh