[logstash] Unable to install Logstash with configured nodePort

[Gagarmel]

Chart version:
7.9.1

Kubernetes version:
v1.15.12

Kubernetes provider: E.g. GKE (Google Kubernetes Engine)
Own

Helm Version:
3.3.0

Provided values.yaml

service:
  type: NodePort
  ports:
    - name: beats
      port: 5044
      protocol: TCP
      nodePort: 31545

Describe the bug:
Due to changes made in #776 it is not possible to install a Logstash instance which has a configured nodePort.

Steps to reproduce:

1. Use the above mentioned values.yaml
2. Install Logstash helm install logstash elastic/logstash -f values.yaml

Expected behavior:
It should be possible to create a Logstash installation with Service type=NodePort and configured nodePort=xxxxx. This was possible in previous versions of this chart.

Provide logs and/or server output (if relevant):

Be careful to obfuscate every secrets (credentials, token, public IP, ...) that could be visible in the output before copy-pasting

Error: Service "logstash-logstash-headless" is invalid: spec.ports[0].nodePort: Forbidden: may not be used when `type` is 'ClusterIP'

Any additional context:

[jmlrt]

Hi @Gagarmel,
Thanks for reporting this bug 👍

Good catch, I didn't test it with NodePort when I reviewed #776 😞.

IMO we should be able to remove totally .Values.service.ports and use only the beat port for the headless service as the headless service should only be used for K8S statefulset management and a real service should be created for other usages.

helm-charts/logstash/templates/service-headless.yaml

Lines 19 to 21 in 6ddd3e3

	{{- if .Values.service }}
	{{ toYaml .Values.service.ports | indent 4 }}
	{{- else }}