Migrate from yaml.v2 to yaml.v3 #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since there is already a dependency on yaml.v3, we might as well upgrade the project to use yaml.v3 too. One change that affected normalizations.yaml was how YAML anchors are merged so I needed to add the `what: user-session` to retain the previous output in tests. Also in normalizations.yaml I noticed there were unused macros and I removed them.
💚 Build Succeeded
|
aleksmaus
approved these changes
May 29, 2024
efd6
approved these changes
May 29, 2024
renini
pushed a commit
to renini/go-libaudit
that referenced
this pull request
Jun 26, 2024
Since there is already a dependency on yaml.v3, we might as well upgrade the project to use yaml.v3 too. One change that affected normalizations.yaml was how YAML anchors are merged so I needed to add the `what: user-session` to retain the previous output in tests. Also in normalizations.yaml I noticed there were unused macros and I removed them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there is already a dependency on yaml.v3, we might as well upgrade the project to use yaml.v3 too.
One change that affected normalizations.yaml was how YAML anchors are merged so I needed to add the
what: user-sessionto retain the previous output in tests.Also in normalizations.yaml I noticed there were unused macros and I removed them.
This relates to GHSA-hp87-p4gw-j4gq which was flagged by Github after intoduction in bebb5c6, but the project is not vulnerable as per https://pkg.go.dev/vuln/GO-2022-0603 because it does not use gopkg.in/yaml.v3#Unmarshal.