[DO NOT MERGE][DRAFT] Base theme setup #8030
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgadewoll
force-pushed
the
eui-theme/124-add-new-theme
branch
2 times, most recently
from
cd61810
to
d19f6c1
Compare
mgadewoll
force-pushed
the
eui-theme/124-add-new-theme
branch
8 times, most recently
from
ab1ae64
to
1596ae7
Compare
- externally created, compiled and imported themes don't pass the class check anymore we can check for the shape additionally
- theme contains only cloned values from current theme
- ensures current state EUI
-removes circle dependency on main eui
build: ensure sass files are added to packed sub packages
- this is a first step, once the overall path si defined we either need to continue moving out more or reverse this partially
mgadewoll
force-pushed
the
eui-theme/124-add-new-theme
branch
from
b81a336
to
7486e9a
Compare
💚 Build Succeeded
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #124
Important
This PR is currently still in
Draftmode, as it needs alignment on some package/dependency specific setups/architectural choices.📖 See additional information here.
🚧 TBA 🚧
QA
Deployments & Theme switcher testing
By default the theme switcher is only enabled for
developmentenvironments.Storybook: https://eui.elastic.co/pr_8030/storybook/?path=/story/navigation-euibutton--playground
EUI docs: https://eui.elastic.co/pr_8030/
EUI+: https://eui.elastic.co/pr_8030/new-docs/
🚧 TBA 🚧