Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiSteps] Remove chroma transparency warning, misc cleanup #7454

Merged
merged 4 commits into from
Jan 9, 2024
Merged

[EuiSteps] Remove chroma transparency warning, misc cleanup #7454

merged 4 commits into from
Jan 9, 2024

Commits on Jan 9, 2024

  1. Remove makeHighContrastColor from disabled EuiSteps 

    - It's creating a `chroma.js` warning that devs are concerned about

- we should really just be reusing the default EuiButton colors anyway, and tweaking those if they have color contrast issues, so that multiple places at once get the updates
    @cee-chen
    cee-chen committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    af063b5 View commit details
    Browse the repository at this point in the history

  2. More DRYing 

    - remove multiple `euiButtonFillColor()` calls in favor of just one
    @cee-chen
    cee-chen committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    998515d View commit details
    Browse the repository at this point in the history

  3. Current step CSS cleanup 

    - remove CSS nesting

- replace hardcoded 2px with token
    @cee-chen
    cee-chen committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    c24613d View commit details
    Browse the repository at this point in the history

  4. changelog

    @cee-chen
    cee-chen committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    6b80f3c View commit details
    Browse the repository at this point in the history