-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiTextTruncate] Performance improvements; Remove non-canvas rendering methods #7210
Commits on Sep 20, 2023
-
[misc minor cleanup] mostly around template literals
Prefer `+` concatenation over template literals, just feels easier to read + minor naming tweaks
Configuration menu - View commit details
-
Copy full SHA for c39feee - Browse repository at this point
Copy the full SHA c39feeeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e279fb - Browse repository at this point
Copy the full SHA 1e279fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bd1d90 - Browse repository at this point
Copy the full SHA 4bd1d90View commit details -
Convert
startEnd
truncation position to use new ratio logic- no longer building text scratch 🎉 - update `middle` to dogfood `startEndAt` function - use `alternating` logic from `middle` for more granular truncation (was previously truncating 2 chars at a time)
Configuration menu - View commit details
-
Copy full SHA for f520bc6 - Browse repository at this point
Copy the full SHA f520bc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e76bd1 - Browse repository at this point
Copy the full SHA 7e76bd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for a5ed6a2 - Browse repository at this point
Copy the full SHA a5ed6a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c4d709 - Browse repository at this point
Copy the full SHA 7c4d709View commit details -
- allow testing greater than 100 lines + fix resize observer on load - initial logic is off due to font not yet loading in - update beta warning - ~100 lines is fairly snappy at this point, and # of characters should no longer be a factor
Configuration menu - View commit details
-
Copy full SHA for f91c032 - Browse repository at this point
Copy the full SHA f91c032View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b45dfc - Browse repository at this point
Copy the full SHA 4b45dfcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a8a1d0 - Browse repository at this point
Copy the full SHA 2a8a1d0View commit details
Commits on Sep 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 782f529 - Browse repository at this point
Copy the full SHA 782f529View commit details -
- underlying mechanism is better described in new comment above ratio utils
Configuration menu - View commit details
-
Copy full SHA for 966369f - Browse repository at this point
Copy the full SHA 966369fView commit details -
[PR feedback] Remove
TruncateUtilsWithDOM
and make canvas the only rendering method + change class inheritance - I'm making canvas text utils its own separate import because there's another component in another PR that will be able to use it soon, that doesn't need truncation logic + remove `measurementRenderAPI` prop
Configuration menu - View commit details
-
Copy full SHA for 7f85043 - Browse repository at this point
Copy the full SHA 7f85043View commit details -
Configuration menu - View commit details
-
Copy full SHA for 810583d - Browse repository at this point
Copy the full SHA 810583dView commit details -
Update/fix tests & performance debugging
+ revert debugging in source code
Configuration menu - View commit details
-
Copy full SHA for 1d1506e - Browse repository at this point
Copy the full SHA 1d1506eView commit details -
Update docs to remove
measurementRenderAPI
+ update copy/recommendations
Configuration menu - View commit details
-
Copy full SHA for 1fda857 - Browse repository at this point
Copy the full SHA 1fda857View commit details