Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiTextTruncate] Performance improvements; Remove non-canvas rendering methods #7210

Merged
merged 16 commits into from
Sep 25, 2023

Commits on Sep 20, 2023

  1. [misc minor cleanup] mostly around template literals

    Prefer `+` concatenation over template literals, just feels easier to read
    
    + minor naming tweaks
    cee-chen committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    c39feee View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1e279fb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4bd1d90 View commit details
    Browse the repository at this point in the history
  4. Convert startEnd truncation position to use new ratio logic

    - no longer building text scratch 🎉
    
    - update `middle` to dogfood `startEndAt` function
    
    - use `alternating` logic from `middle` for more granular truncation (was previously truncating 2 chars at a time)
    cee-chen committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    f520bc6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7e76bd1 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a5ed6a2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7c4d709 View commit details
    Browse the repository at this point in the history
  8. [docs] Improve perf example

    - allow testing greater than 100 lines
    
    + fix resize observer on load - initial logic is off due to font not yet loading in
    
    - update beta warning - ~100 lines is fairly snappy at this point, and # of characters should no longer be a factor
    cee-chen committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    f91c032 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4b45dfc View commit details
    Browse the repository at this point in the history
  10. changelog

    cee-chen committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    2a8a1d0 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. Configuration menu
    Copy the full SHA
    782f529 View commit details
    Browse the repository at this point in the history
  2. Remove now-inaccurate comment

    - underlying mechanism is better described in new comment above ratio utils
    cee-chen committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    966369f View commit details
    Browse the repository at this point in the history
  3. [PR feedback] Remove TruncateUtilsWithDOM

    and make canvas the only rendering method
    
    + change class inheritance - I'm making canvas text utils its own separate import because there's another component in another PR that will be able to use it soon, that doesn't need truncation logic
    
    + remove `measurementRenderAPI` prop
    cee-chen committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    7f85043 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    810583d View commit details
    Browse the repository at this point in the history
  5. Update/fix tests & performance debugging

    + revert debugging in source code
    cee-chen committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    1d1506e View commit details
    Browse the repository at this point in the history
  6. Update docs to remove measurementRenderAPI

    + update copy/recommendations
    cee-chen committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    1fda857 View commit details
    Browse the repository at this point in the history