Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Emotion] Convert EuiBasicTable #6539

Merged
merged 13 commits into from
Jan 23, 2023
Merged

[Emotion] Convert EuiBasicTable #6539

merged 13 commits into from
Jan 23, 2023

Commits on Jan 20, 2023

  1. [tech debt] convert useEuiTheme tests to RTL renderHook 

    - which is generally a nicer API than the one I yolo'd
    @cee-chen
    cee-chen committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    6bcb0a2 View commit details
    Browse the repository at this point in the history

  2. [tech debt] Add more missing unit tests for useEuiTheme

    @cee-chen
    cee-chen committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    3f5e8c1 View commit details
    Browse the repository at this point in the history

  3. [tech debt] write basic unit test for withEuiTheme

    @cee-chen
    cee-chen committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    f396769 View commit details
    Browse the repository at this point in the history

  4. Add new RenderWithEuiTheme render prop util

    @cee-chen
    cee-chen committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    bbe16ef View commit details
    Browse the repository at this point in the history

  5. Convert tbody loading styles to Emotion 

    - I opted not to create a top-level component for this due to the very limited styles being applied, and due to HOC/theme access shenanigans
    @cee-chen
    cee-chen committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    9a5d0c9 View commit details
    Browse the repository at this point in the history

  6. Fix error/empty states not rendering loading styles 

    - by only rendering one `<tbody>`, not multiple
    @cee-chen
    cee-chen committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    3ea3cb6 View commit details
    Browse the repository at this point in the history

  7. Write basic loading test 

    + switch `render` to RTL
    @cee-chen
    cee-chen committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    f9ba5cf View commit details
    Browse the repository at this point in the history

  8. [extra] Massive clean up of EuiBasicTable unit tests 

    - switch to RTL totally (shallow was not handling the new render prop well)
- DRY out various repeated props
- stop use snapshots for every single test - use specific assertions instead. For visual rendering for various prop combos, we should use Storybook
- leave snapshots in for two specific render tests - barebones & kitchen sink props
    @cee-chen
    cee-chen committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    3b6e129 View commit details
    Browse the repository at this point in the history

  9. Delete scss files

    @cee-chen
    cee-chen committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    7563c40 View commit details
    Browse the repository at this point in the history

  10. Add shouldRenderCustomStyles test

    @cee-chen
    cee-chen committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    dfcd39b View commit details
    Browse the repository at this point in the history

  11. changelog

    @cee-chen
    cee-chen committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    c6687c6 View commit details
    Browse the repository at this point in the history

  12. Add affordance for reduced motion media query 

    - this matches how EuiProgress behaves

+ clean up animation shorthand
    @cee-chen
    cee-chen committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    ea9b8d0 View commit details
    Browse the repository at this point in the history

  13. Add CSS workaround/fix for visual Safari bug 

    - apparently `position: relative` on the parent and not on the `tbody` was a cross-browser fix :(
    @cee-chen
    cee-chen committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    6a889eb View commit details
    Browse the repository at this point in the history