Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiButtonGroup] Remove unnecessary shadow #4186

Merged
merged 4 commits into from
Oct 28, 2020

Conversation

miukimiu
Copy link
Contributor

Summary

Before

  • There was a shadow when hovering the EuiButtonGroup
  • The disabled EuiButtonGroup had a shadow on hover and even when not in hover state.

Screen Recording 2020-10-27 at 07 15 PM

After

  • No more shadow on hover of EuiButtonGroup
  • The disabled EuiButtonGroup no longer has a shadow

Screen Recording 2020-10-27 at 07 16 PM

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • [ ] Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • [ ] Props have proper autodocs
  • [ ] Added documentation
  • [ ] Checked Code Sandbox works for the any docs examples
  • [ ] Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@miukimiu miukimiu requested a review from cchaos October 27, 2020 19:29
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4186/

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better. Thanks for the quick fix!

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4186/

@miukimiu
Copy link
Contributor Author

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4186/

@miukimiu miukimiu merged commit e505525 into elastic:master Oct 28, 2020
cchaos pushed a commit to andreadelrio/eui that referenced this pull request Nov 4, 2020
* Removing EuiButtonGroup unnecessary shadow

* Adding CL number

* Moving CL entry to master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants