Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DemoJS docs tab processing to match new raw-loader import format #4027

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

chandlerprall
Copy link
Contributor

Summary

raw-loader was upgraded in #4022 which changed the result of requireing to an ESModule format instead of returning the default export. This PR accesses updates the guide component to add .default when accessing the string value.

A more correct change would be to update every instance of require('!!raw-loader! to import from '!!raw-loader! but that

  1. introduces an eslint warning
  2. requires an automated change to every single example file

These should be solvable, but I'm opting for a quick fix to get the DemoJS tabs working again before going down the more complex path.

Checklist

- [ ] Check against all themes for compatibility in both light and dark modes
- [ ] Checked in mobile
- [ ] Checked in Chrome, Safari, Edge, and Firefox
- [ ] Props have proper autodocs
- [ ] Added documentation

  • Checked Code Sandbox works for the any docs examples
    - [ ] Added or updated jest tests
    - [ ] Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
    - [ ] A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4027/

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working! 🎉

@chandlerprall chandlerprall merged commit 93fc2ff into elastic:master Sep 10, 2020
@chandlerprall chandlerprall deleted the bug/broken-demojs-tabs branch September 10, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants