Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and expand use of EuiSelectable option type generic #3983

Merged
merged 3 commits into from
Sep 1, 2020

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Aug 31, 2020

Summary

Fixes #3966, where the addition of a generic extension of EuiSelectableOption needed to be further propagated to all aspects of EuiSelectable and related components. More types and components accept a generic (defaulted to {}).

To aid TypeScript parsing, the id prop was more explicitly restricted (never instead of Omit, which could have been reinstated with the new generic).

Tested in Kibana with expected updates flagged

Checklist

- [ ] Check against all themes for compatibility in both light and dark modes
- [ ] Checked in mobile
- [ ] Checked in Chrome, Safari, Edge, and Firefox

- [ ] Checked Code Sandbox works for the any docs examples

  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3983/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3983/

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EuiSelectable] onChange needs to account for EuiSelectableOption generic type
3 participants