Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update security analytics app icon #3720

Merged
merged 6 commits into from
Jul 10, 2020

Conversation

miukimiu
Copy link
Contributor

@miukimiu miukimiu commented Jul 9, 2020

Summary

This PR closes #3711.

Design

security analytics app@2x

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • [ ] Checked in mobile
  • [ ] Checked in IE11 and Firefox
  • Props have proper autodocs
  • [ ] Added documentation
  • [ ] Checked Code Sandbox works for the any docs examples
  • [ ] Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@miukimiu miukimiu requested a review from ryankeairns July 9, 2020 16:05
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3720/

Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We used to nitpick and remove the fill="none", but I don't know if that is still the case. Either way, the icon looks correct in both light and dark mode.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3720/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3720/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3720/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Outlined Security Icon to EUI
3 participants