Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade elastic charts 19.6.3 #3669

Merged
merged 5 commits into from
Jun 29, 2020

Conversation

nickofthyme
Copy link
Contributor

@nickofthyme nickofthyme commented Jun 29, 2020

Summary

  • upgrade elastic charts to 19.6.3
  • add background.color to eui chart theme

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

- upgrade elastic charts to 19.6.1
- add background.color to eui chart theme
@nickofthyme nickofthyme requested a review from cchaos June 29, 2020 15:46
@nickofthyme nickofthyme changed the title upgrade elastic charts Upgrade elastic charts Jun 29, 2020
@nickofthyme nickofthyme changed the title Upgrade elastic charts Upgrade elastic charts 19.6.1 Jun 29, 2020
@cchaos
Copy link
Contributor

cchaos commented Jun 29, 2020

Thanks @nickofthyme ! Since this updates a peer-dependency and a consumed output file, it will need a changelog.

@nickofthyme
Copy link
Contributor Author

Ok thanks, I added a note about the src changes.

I wasn't sure what you meant by the peer dependency changes because none of the peer dependencies of @elastic/eui have changed. Are you talking about adding @popperjs/core and chroma-js? If so what should I add?

@chandlerprall
Copy link
Contributor

chandlerprall commented Jun 29, 2020

Pulled up the package.json & yarn.lock changes and compared with our devDeps & peerDeps, this change only affects the former and not peerDeps. No changelog needed (for that change, the background color one is still needed as you have it), but thank you @cchaos for thinking of it!

@nickofthyme nickofthyme changed the title Upgrade elastic charts 19.6.1 Upgrade elastic charts 19.6.3 Jun 29, 2020
@nickofthyme
Copy link
Contributor Author

Ok thanks for the clarification. Thanks @chandlerprall and @cchaos for the review! 👍

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3669/

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll eventually revisit how we are actually doing this and probably want document it. I'll make a note or issue for follow-up.

CHANGELOG.md Outdated Show resolved Hide resolved
@cchaos
Copy link
Contributor

cchaos commented Jun 29, 2020

Meant to also say THANK YOU @nickofthyme !

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3669/

@cchaos cchaos merged commit 86d4497 into elastic:master Jun 29, 2020
@nickofthyme nickofthyme deleted the upgrade-elastic-charts branch July 2, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants