Fixed EuiCode's fullscreen mode #3633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3633/ |
|
Giant network error; jenkins test this |
thompsongl
approved these changes
Jun 18, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3633/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3627
The fullscreen code container's ref wasn't being set in time the
useEffectfired to set its content. This PR moves that ref into a state variable and creates a separateuseEffectto fill it. I added a test and verified it fails without the accompanying changes to EuiCodeBlockImpl.Not sure when/how this bug was introduced, I checked the published docs for the previous 2 PRs touching this file, and fullscreen mode works in both. Perhaps there's a difference in React's dev & production builds affecting this?
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Props have proper autodocs- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Checked for accessibility including keyboard-only and screenreader modes