[EuiToolTip] Improve render performance #3596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3596/ |
|
Pulled this back to draft because, although there are definite improvements, CPU usage in the Kibana issue use case still remains high. |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3596/ |
snide
reviewed
Jun 15, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3596/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3596/ |
snide
reviewed
Jun 15, 2020
chandlerprall
approved these changes
Jun 15, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3596/ |
snide
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #3568 by 1) moving the animation delay from CSS to JS and using it to delay subcomponent mounting and 2) using the
enqueueStateChangeutility to batch EuiToolTip visibility state updates that result in DOM node add/remove updates.Secondary improvement was to remove the EuiToolTipPopover initialization call to
updateDimensions, as the nested EuiResizeObserver component also calls the method on mount.Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation