Upgrade lodash to v4 #1534
Merged
Upgrade lodash to v4 #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandlerprall
suggested changes
Feb 6, 2019
|
This is going to cause issues with Kibana. Kibana is on lodash 3.10.1 and an upgrade would be very difficult |
|
I ran through a number of pages in Kibana built with EUI+lodash 4, specifically looking at places using EUI tables and EUI range slider (tables were previously the known issue, slider relies on two functions from v4) and hit no issues. I don't have a definitive answer why it broke previously, but I strongly suspect it was something with npm's dependency resolution (Kibana was not yet on yarn). |
|
Sounds good. Thanks for checking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #1525.
Gets EUI closer to the aspirations of #360.
Upgrades
lodashdependency from pinned Kibana 3.x fork to latest 4.x. Single biggest benefit is cherry-pickableimports(e.g.,import uniqBy from 'lodash/uniqBy';).Where possible (and simple), I removed the
lodashdependency entirely from files. Mostly, this involved simple methods that ES can handle natively (e.g.,filter,slice, simple array flattening)EUI's heaviest use of
lodashis inservices, specifically the predicate utils. As these are part of the public API, they remain unaltered (verified no breaking changes between v3 and v4). Where possible, we now use methods fromservicesrather import directly fromlodash.Checklist
- [ ] This was checked in mobile- [ ] This was checked in IE11- [ ] This was checked in dark mode- [ ] Any props added have proper autodocs- [ ] Documentation examples were added- [ ] Jest tests were updated or added to match the most common scenarios- [ ] This was checked against keyboard-only and screenreader scenarios- [ ] This required updates to Framer X components