New Component: EUI toolbar button

[rshen91]

In working on elastic/kibana#124372, I'm opening this issue to start a discussion if this component should be taken into EUI vs migration into the shared_ux directory.

[miukimiu]

Hi @rshen91,

I'm looking at the storybook preview, are these the same buttons used in Lens?

In the past, we started a discussion about adding toolbar buttons in EUI:

• Add toolbar button styles #4730

But it was an early discussion and we need a better spec to know what we should build. At the time, we agreed that @MichaelMarcialis is going to pass us the design spec and after that, we can build the new component.

So I think for now the component should live in the shared-ux and soon we let you know the plans for the EUI toolbar button component.

CC / @cchaos @MichaelMarcialis @ryankeairns @chandlerprall

[cchaos]

I agree with @miukimiu that there are no short-term plans to create this button, so don't hold up the Kibana conversion/plugin move.

I do think it's worth evaluating the details of the component to see how it differs from our own buttons and the override nature of the styles. I think somehow this toolbar button was duplicated in Kibana instead of re-used since there's a presentation_util version as well. So I think the first step is to gather up all the similar types of components that exist in Kibana, the similar issues that exist in EUI and start a spec doc.

[ryankeairns]

I recall @cqliu1 dug into the possibility of re-using what existing in Lens, initially, but we ran into some technical roadblocks with that approach so, in the essence of time, made the decision to come back to making these styles reusable.

FWIW, the current toolbar is used in Dashboard and Canvas, currently.

[ryankeairns]

Update: It looks like @andreadelrio did go back and clean this up, making it a shared Kibana component! (thank you) elastic/kibana#88386

[cchaos]

Right, but there are still 2 components within Kibana that seemingly look and behave similarly:

1. Solution toolbar: code; storybook
2. Toolbar button: original code; storybook from PR

At the very least, Shared-UX should evaluate the duplicity of these two components and hopefully consolidate. Then we can see a final set of needs and can evaluate from EUI.

[MichaelMarcialis]

But it was an early discussion and we need a better spec to know what we should build. At the time, we agreed that @MichaelMarcialis is going to pass us the design spec and after that, we can build the new component.

Yes, apologies for the delay on my part. I haven't had a chance to work on this spec since it was discussed in December that I'd assist with writing it up. I'm hoping to have a chance to tackle it towards the end of the 8.2 dev cycle. Will let ya'll know if that changes. Thanks!

[chandlerprall]

We would also want to ensure proper aria roles/labels exist, and include a full toolbar component (see #3500)